Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update Dell.CommandUpdate.Universal to 5.0.0 #122363

Closed

Conversation

FaserF
Copy link
Contributor

@FaserF FaserF commented Oct 11, 2023

  • Have you signed the Contributor License Agreement?
  • Have you checked that there aren't other open pull requests for the same manifest update/change?
  • This PR only modifies one (1) manifest
  • Have you validated your manifest locally with winget validate --manifest <path>?
  • Have you tested your manifest locally with winget install --manifest <path>?
  • Does your manifest conform to the 1.5 schema?

Note: <path> is the name of the directory containing the manifest you're submitting.


Microsoft Reviewers: Open in CodeFlow

@wingetbot
Copy link
Collaborator

Service Badge  Service Badge  

@wingetbot
Copy link
Collaborator

/AzurePipelines run

@azure-pipelines
Copy link

Azure Pipelines successfully started running 1 pipeline(s).

@wingetbot
Copy link
Collaborator

/AzurePipelines run

@azure-pipelines
Copy link

Azure Pipelines successfully started running 1 pipeline(s).

@FaserF
Copy link
Contributor Author

FaserF commented Oct 11, 2023

Hmmm, I dont get the issue here. The URL is valid and works

@microsoft-github-policy-service microsoft-github-policy-service bot added Needs-Attention This work item needs to be reviewed by a member of the core team. and removed Needs-Author-Feedback This needs a response from the author. labels Oct 11, 2023
@stephengillie
Copy link
Collaborator

Automatic Validation ended with:

Installation failed with exit code -1978335226
2023-10-11 01:15:35.434 [CLI ] ShellExecute installer failed: 4

image

@stephengillie
Copy link
Collaborator

stephengillie commented Oct 11, 2023

Manual Validation ended with:
image

@stephengillie stephengillie added Hardware Specific hardware is required to install or validate this package and removed Needs-Attention This work item needs to be reviewed by a member of the core team. labels Oct 11, 2023
@microsoft-github-policy-service microsoft-github-policy-service bot added Blocking-Issue Manifest validation is blocked by a known issue. Needs-Author-Feedback This needs a response from the author. labels Oct 11, 2023
@stephengillie
Copy link
Collaborator

This message is new in this version.

@stephengillie stephengillie removed their assignment Oct 11, 2023
@FaserF
Copy link
Contributor Author

FaserF commented Oct 12, 2023

Yeah that makes sense now that you say it. The program only runs on Dell devices. Anything I can do from my side?

@microsoft-github-policy-service microsoft-github-policy-service bot added Needs-Attention This work item needs to be reviewed by a member of the core team. and removed Needs-Author-Feedback This needs a response from the author. labels Oct 12, 2023
@FaserF
Copy link
Contributor Author

FaserF commented Oct 12, 2023

Wont be merged until microsoft/winget-cli#1417

Therefore I close the PR for now.

@FaserF FaserF closed this Oct 12, 2023
@microsoft-github-policy-service microsoft-github-policy-service bot removed the Needs-Attention This work item needs to be reviewed by a member of the core team. label Oct 12, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Blocking-Issue Manifest validation is blocked by a known issue. Hardware Specific hardware is required to install or validate this package Validation-Shell-Execute
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants