Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Unifi Contoller #131

Merged
5 commits merged into from
May 16, 2020
Merged

Unifi Contoller #131

5 commits merged into from
May 16, 2020

Conversation

KevinLaMS
Copy link
Contributor

@KevinLaMS KevinLaMS commented May 15, 2020 •
edited by ghost
Loading

Microsoft Reviewers: Open in CodeFlow

@wingetbot
Copy link
Collaborator

/AzurePipelines run

@azure-pipelines
Copy link

Azure Pipelines successfully started running 1 pipeline(s).

@wingetbot
Copy link
Collaborator

/AzurePipelines run

@azure-pipelines
Copy link

Azure Pipelines successfully started running 1 pipeline(s).

@wingetbot wingetbot added the Manifest-Validation-Error Manifest validation failed label May 15, 2020
@ghost
Copy link

ghost commented May 15, 2020

KevinLaMS The package manager bot determined that the metadata was not compliant. Be sure to use a tool like VSCode (https://code.visualstudio.com/) to make sure your request is YAML syntax is correct. Please also verify the YAML file is compliant with the package manager specification (https://github.com/microsoft/winget-pkgs/YAMLSpec.md)
For details on the error, see the details link below in the build pipeline.

@wingetbot
Copy link
Collaborator

/AzurePipelines run

@azure-pipelines
Copy link

Azure Pipelines successfully started running 1 pipeline(s).

@wingetbot wingetbot added the Azure-Pipeline-Passed Validation pipeline passed. There may still be manual validation requirements. label May 15, 2020
@ghost ghost assigned KevinLaMS May 15, 2020
@ghost
Copy link

ghost commented May 15, 2020

This submission has moved to manual review.

@denelon
Copy link
Contributor

denelon commented May 15, 2020

This installer depends on Java. I have created an issue to look at supporting external dependencies with the client microsoft/winget-cli#163

@denelon denelon mentioned this pull request May 15, 2020
Closed
@denelon denelon added the Validation-Completed Validation passed label May 16, 2020
@ghost
Copy link

ghost commented May 16, 2020

Hello @denelon!

Because this pull request has the Validation-Completed label, I will be glad to assist with helping to merge this pull request once all check-in policies pass.

p.s. you can customize the way I help with merging this pull request, such as holding this pull request until a specific person approves. Simply @mention me (@msftbot) and give me an instruction to get started! Learn more here.

ghost
ghost approved these changes May 16, 2020
View reviewed changes
Copy link

@ghost ghost left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Validation has completed

@ghost ghost merged commit 1ebe48b into microsoft:master May 16, 2020
This pull request was closed.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
Assignees

@KevinLaMS KevinLaMS

Labels
Azure-Pipeline-Passed Validation pipeline passed. There may still be manual validation requirements. Validation-Completed Validation passed
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@KevinLaMS @wingetbot @denelon