Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

gerardog.gsudo: add portable version to 2.4.2 #131849

Merged
merged 1 commit into from
Jan 5, 2024
Merged

gerardog.gsudo: add portable version to 2.4.2 #131849

merged 1 commit into from
Jan 5, 2024

Conversation

soredake
Copy link
Contributor

@soredake soredake commented Dec 26, 2023 •
edited by microsoft-github-policy-service bot
Loading

  • Have you signed the Contributor License Agreement?
  • Have you checked that there aren't other open pull requests for the same manifest update/change?
  • This PR only modifies one (1) manifest
  • Have you validated your manifest locally with winget validate --manifest <path>?
  • Have you tested your manifest locally with winget install --manifest <path>?
  • Does your manifest conform to the 1.5 schema?

Note: <path> is the name of the directory containing the manifest you're submitting.

Microsoft Reviewers: Open in CodeFlow

This was referenced Dec 26, 2023
Closed
Open
@wingetbot
Copy link
Collaborator

/AzurePipelines run

@azure-pipelines Azure Pipelines
Copy link

Azure Pipelines successfully started running 1 pipeline(s).

@wingetbot wingetbot added the Manifest-Validation-Error Manifest validation failed label Dec 26, 2023
@microsoft-github-policy-service microsoft-github-policy-service bot added the Needs-Author-Feedback This needs a response from the author. label Dec 26, 2023
@soredake
Copy link
Contributor Author

Fixed file name.

@microsoft-github-policy-service microsoft-github-policy-service bot removed Manifest-Validation-Error Manifest validation failed Needs-Author-Feedback This needs a response from the author. labels Dec 26, 2023
@soredake soredake force-pushed the gsudo-portable branch 2 times, most recently from 9fb8b7a to 1d8c67c Compare December 26, 2023 17:15
@wingetbot
Copy link
Collaborator

/AzurePipelines run

@azure-pipelines Azure Pipelines
Copy link

Azure Pipelines successfully started running 1 pipeline(s).

@wingetbot wingetbot added Azure-Pipeline-Passed Validation pipeline passed. There may still be manual validation requirements. Validation-Completed Validation passed labels Dec 26, 2023
@stephengillie
Copy link
Collaborator

Hi @soredake,

Manual Validation ended with:

10:22:38 AM: This command cannot be run due to the error: The specified executable is not a valid application for this OS platform.

Running the EXE opened this dialog:
image

Should the application be interacted with in a different way?

@stephengillie stephengillie added the Needs-Author-Feedback This needs a response from the author. label Dec 27, 2023
auto-merge was automatically disabled December 28, 2023 08:06

Head branch was pushed to by a user without write access

@soredake soredake mentioned this pull request Dec 28, 2023
Open
@microsoft-github-policy-service microsoft-github-policy-service bot removed Validation-Completed Validation passed Azure-Pipeline-Passed Validation pipeline passed. There may still be manual validation requirements. Needs-Author-Feedback This needs a response from the author. labels Dec 28, 2023
@soredake
Copy link
Contributor Author

./ In relative path is needed until microsoft/winget-cli#2884 is fixed.

@wingetbot
Copy link
Collaborator

/AzurePipelines run

@Trenly
Copy link
Contributor

Trenly commented Jan 2, 2024

How does this portable flag works? Is there any way I can test this PR before merging?

You can use winget install --manifest <path_to_manifest> --installer-type portable to specify you want the portable installer and not the msi installer

@stephengillie stephengillie added Needs-Author-Feedback This needs a response from the author. and removed Needs-Attention This work item needs to be reviewed by a member of the core team. labels Jan 4, 2024
@stephengillie
Copy link
Collaborator

/AzurePipelines run

@azure-pipelines Azure Pipelines
Copy link

Azure Pipelines successfully started running 1 pipeline(s).

@microsoft-github-policy-service microsoft-github-policy-service bot removed the Needs-Author-Feedback This needs a response from the author. label Jan 4, 2024
@wingetbot wingetbot added Needs-Attention This work item needs to be reviewed by a member of the core team. Internal-Error-Dynamic-Scan The test for Dynamic Scanning in the Installation Validation failed. labels Jan 4, 2024
@microsoft-github-policy-service microsoft-github-policy-service bot added the Retry-1 flag to indicate retried label Jan 4, 2024
@wingetbot
Copy link
Collaborator

/AzurePipelines run

@azure-pipelines Azure Pipelines
Copy link

Azure Pipelines successfully started running 1 pipeline(s).

@microsoft-github-policy-service microsoft-github-policy-service bot removed Internal-Error-Dynamic-Scan The test for Dynamic Scanning in the Installation Validation failed. Needs-Attention This work item needs to be reviewed by a member of the core team. labels Jan 4, 2024
@wingetbot wingetbot added Azure-Pipeline-Passed Validation pipeline passed. There may still be manual validation requirements. Validation-Completed Validation passed labels Jan 4, 2024
@microsoft-github-policy-service microsoft-github-policy-service bot enabled auto-merge (squash) January 4, 2024 23:07
@stephengillie stephengillie added the Needs-Author-Feedback This needs a response from the author. label Jan 4, 2024
@stephengillie
Copy link
Collaborator

stephengillie commented Jan 4, 2024 •
edited
Loading

Hi @soredake and @gerardog,

Should this be a separate package, with PackageIdentifier gerardog.gsudo.portable as suggested by the title? Or are you happy with adding the portable packages to the existing gerardog.gsudo manifest, as this change performs?

@Trenly
Copy link
Contributor

Trenly commented Jan 4, 2024

Hi @soredake and @gerardog,

Should this be a separate package, with PackageIdentifier gerardog.gsudo.portable as suggested by the title? Or are you happy with adding the portable packages to the existing gerardog.gsudo manifest, as this change performs?

@stephengillie - I suggested previously that it all be one package due to the --installer-type switch now being available; It seems the title was just not updated

@soredake soredake changed the title gerardog.gsudo.portable: add new package gerardog.gsudo: add portable version to 2.4.2 Jan 5, 2024
@stephengillie stephengillie removed the Needs-Author-Feedback This needs a response from the author. label Jan 5, 2024
@stephengillie
Copy link
Collaborator

Oh, sorry to miss that.

@microsoft-github-policy-service microsoft-github-policy-service bot added the Moderator-Approved One of the Moderators has reviewed and approved this PR label Jan 5, 2024
@microsoft-github-policy-service microsoft-github-policy-service bot merged commit d0d21d4 into microsoft:master Jan 5, 2024
@wingetbot
Copy link
Collaborator

Publish pipeline succeeded for this Pull Request. Once you refresh your index, this change should be present.

@gerardog gerardog mentioned this pull request Feb 22, 2024
Closed
1 task
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@gerardog gerardog gerardog left review comments

@Trenly Trenly Trenly requested changes

@microsoft-github-policy-service microsoft-github-policy-service[bot] microsoft-github-policy-service[bot] approved these changes

@stephengillie stephengillie stephengillie approved these changes

Assignees
No one assigned
Labels
Azure-Pipeline-Passed Validation pipeline passed. There may still be manual validation requirements. Moderator-Approved One of the Moderators has reviewed and approved this PR Publish-Pipeline-Succeeded Retry-1 flag to indicate retried Validation-Completed Validation passed
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@soredake @wingetbot @stephengillie @gerardog @Trenly