Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

calibre: fix download links #133008

Closed
wants to merge 1 commit into from
Closed

Conversation

wickles
Copy link
Contributor

@wickles wickles commented Jan 7, 2024

  • Have you signed the Contributor License Agreement?
  • Have you checked that there aren't other open pull requests for the same manifest update/change?
  • This PR only modifies one (1) manifest
  • Have you validated your manifest locally with winget validate --manifest <path>?
  • Have you tested your manifest locally with winget install --manifest <path>?
  • Does your manifest conform to the 1.5 schema?

Note: <path> is the name of the directory containing the manifest you're submitting.


Resolves #133004

Microsoft Reviewers: Open in CodeFlow

@wingetbot
Copy link
Collaborator

Service Badge  Service Badge  

@wingetbot
Copy link
Collaborator

/AzurePipelines run

Copy link

Azure Pipelines successfully started running 1 pipeline(s).

@wickles
Copy link
Contributor Author

wickles commented Jan 7, 2024

@microsoft-github-policy-service agree

@wingetbot wingetbot added the PullRequest-Error PR is Invalid label Jan 7, 2024
@microsoft-github-policy-service microsoft-github-policy-service bot added the Needs-Author-Feedback This needs a response from the author. label Jan 7, 2024
Copy link
Contributor

@OfficialEsco OfficialEsco left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You're not allowed to change multiple manifests, it has to be one version for each PR.

@wickles
Copy link
Contributor Author

wickles commented Jan 7, 2024

@OfficialEsco I would hope an exception could be made here. I'm not splitting this into 6 PRs.

@microsoft-github-policy-service microsoft-github-policy-service bot added Needs-Attention This work item needs to be reviewed by a member of the core team. and removed Needs-Author-Feedback This needs a response from the author. labels Jan 7, 2024
@OfficialEsco
Copy link
Contributor

Oh we mods/top contributors have tried to get a exclusion for a lot more/less and they say ehhhh no

@stephengillie
Copy link
Collaborator

Automatic Validation ended with:

2024-01-07T00:49:02.5100664Z ##[error] The pull request contains more than one manifest. Either singleton or multi file manifest under one version directory.

(Automated response - build 540.)

@stephengillie
Copy link
Collaborator

Hi @wickles,

Thanks for contributing to our repo. This PR modifies 6 manifests:
image

We have a 1 manifest change per PR limit. Could you move 5 of these to other PRs?

@stephengillie stephengillie added Needs-Author-Feedback This needs a response from the author. and removed Needs-Attention This work item needs to be reviewed by a member of the core team. labels Jan 9, 2024
@microsoft-github-policy-service microsoft-github-policy-service bot added the No-Recent-Activity No activity has occurred on this work item for seven days. label Jan 14, 2024
Copy link
Contributor

Hello @wickles,

This pull request has been automatically marked as stale because it has been marked as requiring author feedback but has not had any recent activity. It will be closed if no further activity occurs within 3 days of this comment.

Template: msftbot/noRecentActivity

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Changes-Requested Changes Requested Needs-Author-Feedback This needs a response from the author. No-Recent-Activity No activity has occurred on this work item for seven days. PullRequest-Error PR is Invalid
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Package Issue]: calibre.calibre broken download links
4 participants