Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

New version: MilosParipovic.OneCommander Version 3.65.2 #135820

Conversation

dkr91
Copy link
Contributor

@dkr91 dkr91 commented Jan 23, 2024

  • Have you signed the Contributor License Agreement?
  • Have you checked that there aren't other open pull requests for the same manifest update/change?
  • This PR only modifies one (1) manifest
  • Have you validated your manifest locally with winget validate --manifest <path>?
  • Have you tested your manifest locally with winget install --manifest <path>?
  • Does your manifest conform to the 1.5 schema?

Note: <path> is the name of the directory containing the manifest you're submitting.


Microsoft Reviewers: Open in CodeFlow

@wingetbot
Copy link
Collaborator

Service Badge  Service Badge  

@wingetbot
Copy link
Collaborator

/AzurePipelines run

Copy link

Azure Pipelines successfully started running 1 pipeline(s).

@wingetbot wingetbot added Azure-Pipeline-Passed Validation pipeline passed. There may still be manual validation requirements. Validation-Completed Validation passed labels Jan 23, 2024
@stephengillie
Copy link
Collaborator

Hi @dkr91,

This PR's version number 3.65.2.0 has 4 parameters (sets of numbers between dots - major, minor, etc), which is greater than the current manifest's version 3.44.1, which has 3 parameters.

Is this intentional?

(Automated response - build 629)

@stephengillie stephengillie added the Needs-Author-Feedback This needs a response from the author. label Jan 23, 2024
@dkr91
Copy link
Contributor Author

dkr91 commented Jan 23, 2024

Yes, Milos changed his Versioning.

see [Current release](https://www.onecommander.com/#:~:text=3.66.3.0%20(2024%2D01%2D22)

@microsoft-github-policy-service microsoft-github-policy-service bot added Needs-Attention This work item needs to be reviewed by a member of the core team. and removed Needs-Author-Feedback This needs a response from the author. labels Jan 23, 2024
@stephengillie stephengillie removed the Needs-Attention This work item needs to be reviewed by a member of the core team. label Jan 23, 2024
@microsoft-github-policy-service microsoft-github-policy-service bot merged commit 477020b into microsoft:master Jan 23, 2024
8 checks passed
@microsoft-github-policy-service microsoft-github-policy-service bot added the Moderator-Approved One of the Moderators has reviewed and approved this PR label Jan 23, 2024
@wingetbot
Copy link
Collaborator

Publish pipeline succeeded for this Pull Request. Once you refresh your index, this change should be present.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Azure-Pipeline-Passed Validation pipeline passed. There may still be manual validation requirements. Moderator-Approved One of the Moderators has reviewed and approved this PR Publish-Pipeline-Succeeded Validation-Completed Validation passed
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants