Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

New package: IDRIX.VeraCrypt version 1.26.7 #136114

Closed
wants to merge 5 commits into from
Closed

New package: IDRIX.VeraCrypt version 1.26.7 #136114

wants to merge 5 commits into from

Conversation

vvirtues
Copy link
Contributor

@vvirtues vvirtues commented Jan 24, 2024 •
edited by microsoft-github-policy-service bot
Loading

Pull request has been created with Komac v1.11.0 🚀

Microsoft Reviewers: Open in CodeFlow

@wingetbot
Copy link
Collaborator

Service Badge  Service Badge  

@wingetbot
Copy link
Collaborator

/AzurePipelines run

@vvirtues vvirtues marked this pull request as draft January 24, 2024 23:37
@azure-pipelines Azure Pipelines
Copy link

Azure Pipelines successfully started running 1 pipeline(s).

@vvirtues vvirtues mentioned this pull request Jan 24, 2024
Closed
@microsoft-github-policy-service microsoft-github-policy-service bot added the Needs-Author-Feedback This needs a response from the author. label Jan 24, 2024
@wingetbot
Copy link
Collaborator

/AzurePipelines run

@azure-pipelines Azure Pipelines
Copy link

Azure Pipelines successfully started running 1 pipeline(s).

@vvirtues vvirtues mentioned this pull request Jan 25, 2024
Open
@vvirtues
Copy link
Contributor Author

vvirtues commented Jan 25, 2024 •
edited
Loading

I need some help properly implementing the Argument section
According to the validation bot it doesn't recognize it

@wingetbot wingetbot added Azure-Pipeline-Passed Validation pipeline passed. There may still be manual validation requirements. Validation-Completed Validation passed labels Jan 25, 2024
@vvirtues
Copy link
Contributor Author

image
Can anyone help me implement the agreement prompt? I can't get it to work

@wingetbot
Copy link
Collaborator

/AzurePipelines run

@azure-pipelines Azure Pipelines
Copy link

Azure Pipelines successfully started running 1 pipeline(s).

@microsoft-github-policy-service microsoft-github-policy-service bot removed Validation-Completed Validation passed Azure-Pipeline-Passed Validation pipeline passed. There may still be manual validation requirements. labels Jan 25, 2024
@vvirtues
Copy link
Contributor Author

OK it finally works

@wingetbot
Copy link
Collaborator

/AzurePipelines run

@azure-pipelines Azure Pipelines
Copy link

Azure Pipelines successfully started running 1 pipeline(s).

@wingetbot wingetbot added the Manifest-Validation-Error Manifest validation failed label Jan 25, 2024
@microsoft-github-policy-service microsoft-github-policy-service bot added the Needs-Author-Feedback This needs a response from the author. label Jan 25, 2024
@vvirtues
Copy link
Contributor Author

vvirtues commented Jan 25, 2024 •
edited
Loading

Should I add the ElevationRequirement property or no? seems to cause problems with validation
EDIT: the app does ask for elevation

@microsoft-github-policy-service microsoft-github-policy-service bot added Needs-Attention This work item needs to be reviewed by a member of the core team. and removed Needs-Author-Feedback This needs a response from the author. labels Jan 25, 2024
@vvirtues
Copy link
Contributor Author

vvirtues commented Jan 25, 2024 •
edited
Loading

The program does not uninstall properly, will remain draft
edit: might be because it isn't in the actual repo yet, but still needs review

@Trenly
Copy link
Contributor

Trenly commented Jan 25, 2024

I need some help properly implementing the Argument section According to the validation bot it doesn't recognize it

Correct. The Microsoft team is working on getting a solution in place to allow the Agreements field in manifests. Until this field is available, VeraCrypt won't be able to be added to the repo (unless they change the installer to no longer require ACCEPTLICENSE=YES)

@vvirtues vvirtues marked this pull request as ready for review January 29, 2024 14:56
@stephengillie
Copy link
Collaborator

Automatic Validation ended with:

2024-01-25T16:47:51.3821263Z ##[error] Manifest Error: Schema Error. [Schema validation failed. Error context: [ElevationRequirement] Description: Failed to match against any enum values. Error context: Description: Failed to validate against schema associated with property name 'ElevationRequirement'. ] File: IDRIX.VeraCrypt.installer.yaml Manifest Error: Field usage requires verified publishers. [Agreements]

(Automated response - build 675.)

@stephengillie stephengillie added Needs-Author-Feedback This needs a response from the author. and removed Needs-Attention This work item needs to be reviewed by a member of the core team. labels Jan 29, 2024
@vvirtues @stephengillie
Change to camelCase
5692799 
thanks @stephengillie

Co-authored-by: Stephen Gillie <114952565+stephengillie@users.noreply.github.com>
@wingetbot
Copy link
Collaborator

/AzurePipelines run

@azure-pipelines Azure Pipelines
Copy link

Azure Pipelines successfully started running 1 pipeline(s).

@microsoft-github-policy-service microsoft-github-policy-service bot removed Manifest-Validation-Error Manifest validation failed Needs-Author-Feedback This needs a response from the author. labels Jan 29, 2024
@wingetbot wingetbot added the Manifest-Validation-Error Manifest validation failed label Jan 29, 2024
@stephengillie
Copy link
Collaborator

Automatic Validation ended with:

2024-01-29T21:50:17.8285962Z ##[error] Manifest Error: Field usage requires verified publishers. [Agreements]

(Automated response - build 679.)

@stephengillie stephengillie added the Agreements This package uses the Agreements section, and is pending feature completion. label Jan 30, 2024
@Trenly
Copy link
Contributor

Trenly commented Feb 16, 2024

The older version has been restored to the repo with the proper agreements. You should be able to use Komac to submit a new PR for this version, which should automatically pull in the agreements from the version in the repo

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@stephengillie stephengillie stephengillie left review comments

Assignees
No one assigned
Labels
Agreements This package uses the Agreements section, and is pending feature completion. Manifest-Validation-Error Manifest validation failed
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@vvirtues @wingetbot @Trenly @stephengillie