Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

New package: TCHelicon.GoXLRApp version 1.3.3.130 #137805

Open
wants to merge 2 commits into
base: master
Choose a base branch
from

Conversation

Exorcism0666
Copy link
Contributor

@Exorcism0666 Exorcism0666 commented Feb 4, 2024

Pull request has been created with komac v2.0.3 🚀

Microsoft Reviewers: Open in CodeFlow

@Exorcism0666
Copy link
Contributor Author

For moderators

This account is automated by Github Actions and the source code was created by CoolPlayLin. If you have any questions about any pull request, don't hesitate to ping @Exorcism0666, I'll get a notification.

Important

Please carefully review these Pull Request before merging. If it is a Pull Request for removing incorrect content and the URLs are issue, free upon manual checking, please close this Pull Request directly. (It is best to inform Exorcism0666 of the closure.)

良い一日をお過ごしください!

@wingetbot
Copy link
Collaborator

/AzurePipelines run

Copy link

Azure Pipelines successfully started running 1 pipeline(s).

@wingetbot wingetbot added the Validation-Unattended-Failed During installation testing the installer was blocked on user input and no switches were provided. label Feb 4, 2024
@microsoft-github-policy-service microsoft-github-policy-service bot added the Needs-Author-Feedback This needs a response from the author. label Feb 4, 2024
@stephengillie
Copy link
Collaborator

Automatic Validation ended with:

No errors to post.

(Automated response - build 695.)

@stephengillie
Copy link
Collaborator

Automatic Validation ended with:
image

Hi @Exorcism0666,

Is an installer switch missing?

@microsoft-github-policy-service microsoft-github-policy-service bot removed Validation-Unattended-Failed During installation testing the installer was blocked on user input and no switches were provided. Needs-Author-Feedback This needs a response from the author. labels Feb 5, 2024
@wingetbot
Copy link
Collaborator

/AzurePipelines run

Copy link

Azure Pipelines successfully started running 1 pipeline(s).

@wingetbot wingetbot added the Validation-Unattended-Failed During installation testing the installer was blocked on user input and no switches were provided. label Feb 5, 2024
@microsoft-github-policy-service microsoft-github-policy-service bot added the Needs-Author-Feedback This needs a response from the author. label Feb 5, 2024
@stephengillie
Copy link
Collaborator

Automatic Validation ended with:

No errors to post.

(Automated response - build 719.)

@stephengillie
Copy link
Collaborator

Automatic Validation ended with: image

Hi @Exorcism0666,

Is an installer switch missing?

@stephengillie
Copy link
Collaborator

The /SILENT and /VERYSILENT switches should be working.
image

@stephengillie stephengillie added the DriverInstall Package includes driver software that needs to be manually installed. label Feb 9, 2024
@stephengillie
Copy link
Collaborator

This is actually 2 installers - the app installer runs a driver installer:

Image of an installer window on the upper left, partially covered with a driver installer window.

Both look the same and have similar names, which makes them seem like the same installer. The silent installer switches are working as expected. But they fail to work on the driver installer, which is common.

It's unlikely that silent install switches exist for the driver. If they do, the PR could proceed.

@Exorcism0666
Copy link
Contributor Author

@stephengillie What change do you propose?

@microsoft-github-policy-service microsoft-github-policy-service bot added Needs-Attention This work item needs to be reviewed by a member of the core team. and removed Needs-Author-Feedback This needs a response from the author. labels Feb 9, 2024
@stephengillie
Copy link
Collaborator

stephengillie commented Feb 9, 2024

@Exorcism0666,

Unfortunately, packages like this - involving a driver install - usually get blocked at this step. The problem is that the main installer launches a nested driver installer. Installers nested in this way are hard to reach to provide installer switches, without disassembling the installer file. And driver installs usually require explicit user permission in addition to elevated permissions.

Potential paths forward:

  • Locate installer switches that would inform the main installer to silently install the driver.
  • Find the driver package separately, find silent installer switches, add driver package manifest to repo, include driver package as dependency in main package.
  • Find another method to install this driver before the package, if one exists.
  • Create your own driver installer to install this driver, with silent installer switches. Follow remaining steps from 2nd bullet point.

@stephengillie
Copy link
Collaborator

  • Find the driver package separately, find silent installer switches, add driver package manifest to repo, include driver package as dependency in main package.

This might be the goal with this PR:

@microsoft-github-policy-service microsoft-github-policy-service bot added the Moderator-Approved One of the Moderators has reviewed and approved this PR label Sep 2, 2024
@ItzLevvie
Copy link
Contributor

[Policy] Blocking-Issue

@microsoft-github-policy-service microsoft-github-policy-service bot added Blocking-Issue Manifest validation is blocked by a known issue. and removed Needs-Attention This work item needs to be reviewed by a member of the core team. labels Sep 7, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Blocking-Issue Manifest validation is blocked by a known issue. DriverInstall Package includes driver software that needs to be manually installed. Moderator-Approved One of the Moderators has reviewed and approved this PR Validation-Unattended-Failed During installation testing the installer was blocked on user input and no switches were provided.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Package Request]: TCHelicon.GoXLRApp
4 participants