Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

OpenSSL Light 1.1.1k #13968

Merged
5 commits merged into from
May 26, 2021
Merged

OpenSSL Light 1.1.1k #13968

5 commits merged into from
May 26, 2021

Conversation

auanasgheps
Copy link
Contributor

@auanasgheps auanasgheps commented May 26, 2021

Re-Added

  • Have you signed the Contributor License Agreement?
  • Have you checked that there aren't other open pull requests for the same manifest update/change?
  • Have you validated your manifest locally with winget validate --manifest <path>?
  • Have you tested your manifest locally with winget install --manifest <path>?
  • Does your manifest conform to the 1.0 schema?

Note: <path> is the name of the directory containing the manifest you're submitting.


Microsoft Reviewers: Open in CodeFlow

@wingetbot
Copy link
Collaborator

/AzurePipelines run

@azure-pipelines
Copy link

Azure Pipelines successfully started running 1 pipeline(s).

@wingetbot wingetbot added the Manifest-Validation-Error Manifest validation failed label May 26, 2021
@ghost
Copy link

ghost commented May 26, 2021

Hello @auanasgheps,
The package manager bot determined that the metadata was not compliant.

As mentioned in this tweet, in winget-cli and winget-pkgs we have moved to the 1.0 format. Please update your manifest to the new format and submit again.
Make sure the ID is of the form publisher.appname and that the folder structure is manifests\partition\publisher\appname\version. Be sure to use a tool like VSCode (https://code.visualstudio.com/) to make sure your request is YAML syntax is correct. Please also verify the manifest file is compliant with the package manager specification (https://github.com/microsoft/winget-cli/blob/master/doc/ManifestSpecv1.0.md)
For details on the error, see the details link below in the build pipeline.

@lychichem
Copy link
Contributor

lychichem commented May 26, 2021

  1. The manifest schema has switched to 1.0 from 0.1. Do not use 0.1 anymore, otherwise your submission will be rejected again and again.
  2. As far as I know, this package needs VC runtime to install, which is currently not supported by winget.

@auanasgheps
Copy link
Contributor Author

auanasgheps commented May 26, 2021

Thank you, will regenerate the Manifest and try again. I though was already at 1.0

@KaranKad
Copy link
Contributor

KaranKad commented May 26, 2021

PackageIdentifier: ShiningLight.OpenSSLLight
PackageVersion: 1.0.0
PackageLocale: en-US
Publisher: Shining Light
PublisherUrl: https://slproweb.com/
PackageName: OpenSSL
PackageUrl: https://slproweb.com/products/Win32OpenSSL.html
License: Apache License 2.0
ShortDescription: The Win32/Win64 OpenSSL Installation Project is dedicated to providing a simple installation of OpenSSL for Microsoft Windows.
Moniker: openssl
Tags:
 - openssl
 - tools
 - ssl
Installers: 
 - Architecture: x64
   InstallerType: msi
   InstallerUrl: https://slproweb.com/download/Win64OpenSSL_Light-1_1_1k.msi
   InstallerSha256: CF29DD125D0FFF9A6A0C20A708B89958738A51F6BB1CD8CBD3BB09010F096D92
   ProductCode: "{1D081372-FA6C-42B1-95C6-C837AFAEDF0E}"
ManifestType: singleton
ManifestVersion: 1.0.0

And the folder structure should look like this
manifests/s/ShiningLight/OpenSSLLight/1.0.0/ShiningLight.OpenSSLLight.yaml

@ghost ghost removed Manifest-Validation-Error Manifest validation failed Needs: Attention labels May 26, 2021
@wingetbot
Copy link
Collaborator

/AzurePipelines run

@azure-pipelines
Copy link

Azure Pipelines successfully started running 1 pipeline(s).

Copy link
Contributor Author

@auanasgheps auanasgheps left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Update

…/s/ShiningLight/OpenSSLLight/1.1.1k/ShiningLight.OpenSSLLight.yaml.yaml
Copy link
Contributor Author

@auanasgheps auanasgheps left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Rename

@wingetbot
Copy link
Collaborator

/AzurePipelines run

@azure-pipelines
Copy link

Azure Pipelines successfully started running 1 pipeline(s).

@wingetbot
Copy link
Collaborator

/AzurePipelines run

@azure-pipelines
Copy link

Azure Pipelines successfully started running 1 pipeline(s).

@KaranKad
Copy link
Contributor

KaranKad commented May 26, 2021

I set the package version to 1.0.0 because after installing the app that's what it said in the control panel.

@wingetbot wingetbot added the Manifest-Validation-Error Manifest validation failed label May 26, 2021
@ghost
Copy link

ghost commented May 26, 2021

Hello @auanasgheps,
The package manager bot determined that the metadata was not compliant.

As mentioned in this tweet, in winget-cli and winget-pkgs we have moved to the 1.0 format. Please update your manifest to the new format and submit again.
Make sure the ID is of the form publisher.appname and that the folder structure is manifests\partition\publisher\appname\version. Be sure to use a tool like VSCode (https://code.visualstudio.com/) to make sure your request is YAML syntax is correct. Please also verify the manifest file is compliant with the package manager specification (https://github.com/microsoft/winget-cli/blob/master/doc/ManifestSpecv1.0.md)
For details on the error, see the details link below in the build pipeline.

@KaranKad
Copy link
Contributor

There is one extra .yaml in the file name

@auanasgheps
Copy link
Contributor Author

I set the package version to 1.0.0 because after installing the app that's what it said in the control panel.

Interesting, they changed something

In version 1.1.1d which was installed on one of my PCs, it didn't report any version in such field, but only in the name field.
Now the version in the name field is gone, but the package is 1.0.0 as you reported.
Still, I think we need to show the real OpenSSL version otherwise it won't work for updates.

@ghost ghost removed Manifest-Validation-Error Manifest validation failed Needs: Attention labels May 26, 2021
@wingetbot
Copy link
Collaborator

/AzurePipelines run

@azure-pipelines
Copy link

Azure Pipelines successfully started running 1 pipeline(s).

@KaranKad
Copy link
Contributor

KaranKad commented May 26, 2021

Winget currently uses app version that is shown in control panel to determine if the app has to update or no, now this app is reported 1.0.0 in control panel but 1.1.1k in manifest. Winget will think this app has update even if it actually does not.
Its related to this issue microsoft/winget-cli#980 and microsoft/winget-cli#976

@auanasgheps
Copy link
Contributor Author

Winget currently uses app version that is shown in control panel to determine if the app has to update or no, now this app is reported 1.0.0 in control panel but 1.1.1k in manifest. Winget will think this app has update even if it actually does not.
Its related to this issue microsoft/winget-cli#980 and microsoft/winget-cli#976

Allright, so we have to choose between always upgrade or never upgrade?

@wingetbot wingetbot added Azure-Pipeline-Passed Validation pipeline passed. There may still be manual validation requirements. Validation-Completed Validation passed labels May 26, 2021
@ghost
Copy link

ghost commented May 26, 2021

Hello @wingetbot!

Because this pull request has the Validation-Completed label, I will be glad to assist with helping to merge this pull request once all check-in policies pass.

p.s. you can customize the way I help with merging this pull request, such as holding this pull request until a specific person approves. Simply @mention me (@msftbot) and give me an instruction to get started! Learn more here.

Copy link

@ghost ghost left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hello @${issueAuthor},
Validation has completed.

@ghost ghost merged commit a4ab088 into microsoft:master May 26, 2021
@auanasgheps auanasgheps deleted the patch-1 branch May 26, 2021 10:55
This pull request was closed.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Azure-Pipeline-Passed Validation pipeline passed. There may still be manual validation requirements. Validation-Completed Validation passed
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants