-
Notifications
You must be signed in to change notification settings - Fork 4.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
New package: Oven-sh.Bun version 1.1.0 #147222
New package: Oven-sh.Bun version 1.1.0 #147222
Conversation
/AzurePipelines run |
Azure Pipelines successfully started running 1 pipeline(s). |
/AzurePipelines run |
Azure Pipelines successfully started running 1 pipeline(s). |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
As suggested by @paperdave, a CPU check like this would be nice, but I guess it's not possible with Winget yet:
if (-not (Add-Type -MemberDefinition '[DllImport("kernel32.dll")] public static extern bool IsProcessorFeaturePresent(int ProcessorFeature);'-Name 'Kernel32'-Namespace 'Win32'-PassThru)::IsProcessorFeaturePresent(40)) {
Write-Host -Foreground Red "This CPU does not support the AVX2 instruction set. Please install 'Oven-sh.Bun.Baseline' instead."
}
Yes, I don't think that's possible with WinGet. We can have a note printed out after installation though that says something like:
|
Co-authored-by: sitiom <sitiom@proton.me>
/AzurePipelines run |
Azure Pipelines successfully started running 1 pipeline(s). |
/AzurePipelines run |
Azure Pipelines successfully started running 1 pipeline(s). |
f6e3a56
into
microsoft:master
Publish pipeline succeeded for this Pull Request. Once you refresh your index, this change should be present. |
After microsoft/winget-pkgs#147222, `bun` can be installed via [`winget`](https://learn.microsoft.com/en-us/windows/package-manager/winget/) package manager.
NestedInstallerType: portable | ||
NestedInstallerFiles: | ||
- RelativeFilePath: bun-windows-x64\bun.exe | ||
PortableCommandAlias: bun |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I forgot about this too, a bunx
alias for bun x
(Bun automatically detects the naming):
PortableCommandAlias: bun | |
PortableCommandAlias: bun | |
- RelativeFilePath: .\bun-windows-x64\bun.exe | |
PortableCommandAlias: bunx |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Checklist for Pull Requests
Manifests
winget validate --manifest <path>
?winget install --manifest <path>
?Note:
<path>
is the name of the directory containing the manifest you're submitting.Microsoft Reviewers: Open in CodeFlow