Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

EA Origin Client v10.5.72.41482 #2046

Closed
wants to merge 1 commit into from
Closed

EA Origin Client v10.5.72.41482 #2046

wants to merge 1 commit into from

Conversation

Vivacio
Copy link
Contributor

@Vivacio Vivacio commented Jun 22, 2020 •
edited by ghost
Loading

Added the current Origin game launcher for installation

Microsoft Reviewers: Open in CodeFlow

@wingetbot
Copy link
Collaborator

/AzurePipelines run

@azure-pipelines
Copy link

Azure Pipelines successfully started running 1 pipeline(s).

@ghost
Copy link

ghost commented Jun 22, 2020 •
edited by ghost
Loading

CLA assistant check
All CLA requirements met.

@wingetbot wingetbot added the Azure-Pipeline-Passed Validation pipeline passed. There may still be manual validation requirements. label Jun 22, 2020
@ghost
Copy link

ghost commented Jun 22, 2020

This submission has moved to manual review.

@ghost ghost assigned denelon Jun 22, 2020
@ghost
Copy link

ghost commented Jun 23, 2020

Greetings. This package fails because it is dependent on the Visual Studio Runtime and we do not support the dependencies yet. See issue: microsoft/winget-cli#163

In the meantime, if you include the dependencies in your package, it should pass.
https://support.microsoft.com/en-us/help/2977003/the-latest-supported-visual-c-downloads

@ghost ghost added Needs: author feedback Blocking-Issue Manifest validation is blocked by a known issue. and removed Azure-Pipeline-Passed Validation pipeline passed. There may still be manual validation requirements. labels Jun 23, 2020
@KevinLaMS
Copy link
Contributor

i am running into an error due to a dependency.
The code execution cannot proceed because MSVCP140.dll was not found. Reinstalling the program may fix this problem.

@Vivacio
Copy link
Contributor Author

Vivacio commented Jun 24, 2020

Ah sorry there! Reminds me i need to work in setting up a redeployable workstation to do clean tests of installs so thanks for that! :)

As i understand from the bot response, currently there is no option yet to mark dependencies or add them right?

If so i'll close the pull request and look back into it when that is possible (since the launcher will most definitely have an update as well.)

@ghost ghost removed the Needs: author feedback label Jun 24, 2020
@Vivacio Vivacio closed this Jun 26, 2020
@Vivacio
Copy link
Contributor Author

Vivacio commented Jun 26, 2020

Closing the pull request and will update when the dependencies can be added to the manifest

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@denelon denelon

Labels
Blocking-Issue Manifest validation is blocked by a known issue.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@Vivacio @wingetbot @KevinLaMS @denelon