Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

ARP/ProductCode: martinchrzan.ColorPicker version 1.1.0 #22408

Merged
4 commits merged into from
Jul 26, 2021
Merged

ARP/ProductCode: martinchrzan.ColorPicker version 1.1.0 #22408

4 commits merged into from
Jul 26, 2021

Conversation

vedantmgoyal9
Copy link
Contributor

@vedantmgoyal9 vedantmgoyal9 commented Jul 26, 2021 •
edited
Loading

  • Have you signed the Contributor License Agreement?
  • Have you checked that there aren't other open pull requests for the same manifest update/change?
  • Have you validated your manifest locally with winget validate --manifest <path>?
  • Have you tested your manifest locally with winget install --manifest <path>?
  • Does your manifest conform to the 1.0 schema?

Note: <path> is the name of the directory containing the manifest you're submitting.

Microsoft Reviewers: Open in CodeFlow

@wingetbot
Copy link
Collaborator

/AzurePipelines run

@vedantmgoyal9
Update and rename manifests/m/martinchrzan/ColorPicker/1.1.0/martinch…
8d1b380 
…rzan.ColorPicker.installer.yaml to manifests/m/martinchrzan/ColorPicker/1.1.0.0/martinchrzan.ColorPicker.installer.yaml
@azure-pipelines
Copy link

No commit pushedDate could be found for PR 22408 in repo microsoft/winget-pkgs

@wingetbot
Copy link
Collaborator

/AzurePipelines run

@vedantmgoyal9
Update and rename manifests/m/martinchrzan/ColorPicker/1.1.0/martinch…
faa0622 
…rzan.ColorPicker.locale.en-US.yaml to manifests/m/martinchrzan/ColorPicker/1.1.0.0/martinchrzan.ColorPicker.locale.en-US.yaml
@azure-pipelines
Copy link

Comment was made before the most recent commit for PR 22408 in repo microsoft/winget-pkgs

@wingetbot
Copy link
Collaborator

/AzurePipelines run

1 similar comment
@wingetbot
Copy link
Collaborator

/AzurePipelines run

@vedantmgoyal9
Update and rename manifests/m/martinchrzan/ColorPicker/1.1.0/martinch…
eb5384c 
…rzan.ColorPicker.yaml to manifests/m/martinchrzan/ColorPicker/1.1.0.0/martinchrzan.ColorPicker.yaml
@azure-pipelines
Copy link

Azure Pipelines successfully started running 1 pipeline(s).

1 similar comment
@azure-pipelines
Copy link

Azure Pipelines successfully started running 1 pipeline(s).

@wingetbot
Copy link
Collaborator

/AzurePipelines run

1 similar comment
@wingetbot
Copy link
Collaborator

/AzurePipelines run

@azure-pipelines
Copy link

Azure Pipelines successfully started running 1 pipeline(s).

1 similar comment
@azure-pipelines
Copy link

Azure Pipelines successfully started running 1 pipeline(s).

@wingetbot wingetbot added Azure-Pipeline-Passed Validation pipeline passed. There may still be manual validation requirements. Validation-Completed Validation passed labels Jul 26, 2021
@ghost
Copy link

ghost commented Jul 26, 2021

Hello @wingetbot!

Because this pull request has the Validation-Completed label, I will be glad to assist with helping to merge this pull request once all check-in policies pass.

p.s. you can customize the way I help with merging this pull request, such as holding this pull request until a specific person approves. Simply @mention me (@msftbot) and give me an instruction to get started! Learn more here.

@wingetbot wingetbot added Validation-Completed Validation passed and removed Validation-Completed Validation passed labels Jul 26, 2021
@ghost ghost added the Moderator-Approved One of the Moderators has reviewed and approved this PR label Jul 26, 2021
@ghost
Copy link

ghost commented Jul 26, 2021

Hello @vedantmgoyal2009,
Validation has completed.

@ghost ghost merged commit 1526df1 into microsoft:master Jul 26, 2021
@OfficialEsco
Copy link
Contributor

This is actually wrong and needs special treatment

@vedantmgoyal9 vedantmgoyal9 deleted the martinchrzan.ColorPicker-1.1.0 branch July 26, 2021 16:03
@OfficialEsco
Copy link
Contributor

Since this is something you can fix instead of spamming Metadata PR's you can fix this:
Replace all the MSI's with the EXE's found on their GitHub Release page, the silent switch is --silent
The version is 3 digit
image
Move the MSI's to martinchrzan.ColorPicker.MachineWide with the PackageName Machine-Wide Installer to match against any version or since you have the ProductCode you can do Color Picker Machine-Wide Installer to match against any version which have a ProductCode.

@vedantmgoyal9
Copy link
Contributor Author

Ok, so you mean to move the MSI installers to martinchrzan.ColorPicker.MachineWide and add EXE installers to martinchrzan.ColorPicker with 3 digit versions and Scope:user.

@OfficialEsco
Copy link
Contributor

Ok, so you mean to move the MSI installers to martinchrzan.ColorPicker.MachineWide and add EXE installers to martinchrzan.ColorPicker with 3 digit versions and Scope:user.

Yes, could technically be martinchrzan.ColorPicker.User but we'll see if they find a way to merge Machine Wide installers and User Installers
My issue on this: #14115
Related: microsoft/winget-cli#982
Suggestion: microsoft/winget-cli#1073
Included in Manifest Schema v1.1.0 microsoft/winget-cli#1243

Nevermind the martinchrzan.ColorPicker.MachineWide suggestion, add the User install in the Manifest and keep the MSI version, then we can fix this once v1.1.0 comes out

@OfficialEsco
Copy link
Contributor

Add uninstallPrevious as the upgrade behavior for the MSI
image

@vedantmgoyal9
Copy link
Contributor Author

vedantmgoyal9 commented Jul 26, 2021 •
edited
Loading

Well, I will have to delete the existing manifests and then add all manifests again in separate PRs. It is throwing an error that the addition and deletion of manifests should be in the same directory.

@vedantmgoyal9
Copy link
Contributor Author

If you can approve #22411 #22412 #22413 #22414 #22415 #22416 #22418 #22419 #22420 #22421 otherwise new PRs will be flagged as duplicates.

@OfficialEsco
Copy link
Contributor

If you can approve #22411 #22412 #22413 #22414 #22415 #22416 #22418 #22419 #22420 #22421 otherwise new PRs will be flagged as duplicates.

Hold up, what kind of folder structure are you going to do?

@vedantmgoyal9
Copy link
Contributor Author

vedantmgoyal9 commented Jul 26, 2021 •
edited
Loading

I will put EXE installers under martinchrzan.ColorPicker.User and MSI installers under martinchrzan.ColorPicker.MachineWide

@OfficialEsco
Copy link
Contributor

I will put EXE installers under martinchrzan.ColorPicker.User and MSI installers under martinchrzan.ColorPicker.MachineWide

Ahh sorry for confusing you, because microsoft/winget-cli#1243 will be implemented Soon™ we can do both in martinchrzan.ColorPicker

@vedantmgoyal9
Copy link
Contributor Author

Please explain to me from the beginning what you want to say.

@OfficialEsco
Copy link
Contributor

When i follow this thread:

My issue on this: #14115
Related: microsoft/winget-cli#982
Suggestion: microsoft/winget-cli#1073
Included in Manifest Schema v1.1.0 microsoft/winget-cli#1243

Nevermind the martinchrzan.ColorPicker.MachineWide suggestion, add the User install in the Manifest and keep the MSI version, then we can fix this once v1.1.0 comes out

i realized the fix was close, therefore you can add the EXE and MSI in martinchrzan.ColorPicker under the MSI Version name

@vedantmgoyal9
Copy link
Contributor Author

Ok, so you approve the PRs and I will create new PRs with EXE and MSI installers under the MSI version name. Because I deleted my manifests it will time taking to revert commits rather than creating them from scratch.

@OfficialEsco
Copy link
Contributor

Seems like the bot died

@denelon
Copy link
Contributor

denelon commented Aug 3, 2021

@OfficialEsco the bot just can't keep up with you 😂

This pull request was closed.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@OfficialEsco OfficialEsco OfficialEsco approved these changes

Assignees
No one assigned
Labels
Azure-Pipeline-Passed Validation pipeline passed. There may still be manual validation requirements. Moderator-Approved One of the Moderators has reviewed and approved this PR Validation-Completed Validation passed
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@vedantmgoyal9 @wingetbot @OfficialEsco @denelon