Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove Okular #2368

Merged
1 commit merged into from
Jul 8, 2020
Merged

Remove Okular #2368

1 commit merged into from
Jul 8, 2020

Conversation

mimi89999
Copy link
Contributor

@mimi89999 mimi89999 commented Jul 8, 2020

  • Have you signed the Contributor License Agreement?
  • Have you checked that there aren't other open pull requests for the same manifest update/change?
  • Have you validated your manifest locally with winget validate <manifest>, where <manifest> is the name of the manifest you're submitting?
  • Have you tested your manifest locally with winget install -m <manifest>?

KDE's binary-factory only keeps last 10 build artifacts and builds are daily. A manifest would work for max 10 days. Unless

I don't see how those apps can stay in the repo. I also missed that when adding Okular to just-install and had to remove it later (just-install/registry#204).

Microsoft Reviewers: Open in CodeFlow

@wingetbot
Copy link
Collaborator

/AzurePipelines run

@azure-pipelines
Copy link

Azure Pipelines successfully started running 1 pipeline(s).

@wingetbot wingetbot added the Azure-Pipeline-Passed Validation pipeline passed. There may still be manual validation requirements. label Jul 8, 2020
@ghost ghost assigned KevinLaMS Jul 8, 2020
@ghost
Copy link

ghost commented Jul 8, 2020

This submission has moved to manual review.

@denelon denelon added the Validation-Completed Validation passed label Jul 8, 2020
@ghost
Copy link

ghost commented Jul 8, 2020

Hello @denelon!

Because this pull request has the Validation-Completed label, I will be glad to assist with helping to merge this pull request once all check-in policies pass.

p.s. you can customize the way I help with merging this pull request, such as holding this pull request until a specific person approves. Simply @mention me (@msftbot) and give me an instruction to get started! Learn more here.

Copy link

@ghost ghost left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Validation has completed

@ghost ghost merged commit 5c3a7a3 into microsoft:master Jul 8, 2020
@mimi89999 mimi89999 deleted the okular branch December 6, 2020 12:06
This pull request was closed.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Azure-Pipeline-Passed Validation pipeline passed. There may still be manual validation requirements. Validation-Completed Validation passed
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants