-
Notifications
You must be signed in to change notification settings - Fork 4.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add Adobe.Acrobat.Reader.64-Bit v21.007.20099 #33539
Conversation
/AzurePipelines run |
Azure Pipelines successfully started running 1 pipeline(s). |
CopyrightUrl: https://www.adobe.com/content/dam/cc/en/legal/licenses-terms/pdf/Reader-EULA-en_US-20181207.pdf | ||
ShortDescription: The free global standard for reliably viewing, printing, signing, and commenting on PDF documents. | ||
Description: Adobe Acrobat Reader DC software is the free, trusted global standard for viewing, printing, signing, sharing, and annotating PDFs. It's the only PDF viewer that can open and interact with all types of PDF content – including forms and multimedia. | ||
Moniker: acrobatreader |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Moniker: acrobatreader | |
Moniker: adobe-reader |
People usually refer to this app in speech as Adobe Reader. Unless someone has an objection, the moniker should probably be changed.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I was simply going with what was originally in the 32-bit version; I don't have an objection to changing it, but addiitonal opinions would be appreciated
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We shouldn't have a moniker pointing to two different PackageIdentifiers, that means you can't use it to install the package. So maybe adobe-reader-x64
?
Hello @wingetbot! Because this pull request has the p.s. you can customize the way I help with merging this pull request, such as holding this pull request until a specific person approves. Simply @mention me (
|
Hello @Trenly, |
Publish pipeline succeeded for this Pull Request. Once you refresh your index, this change should be present. |
I have microsoft/winget-cli#906 in the backlog to support specifying architecture settings/preferences. I believe we default to the "best" architecture for the available installers. I'm not sure there is a reason to have a separate package. |
I specifically chose the package identifier to allow for Adobe.Acrobat.Pro to be added later.
This is required to be separate from the 32-bit version until the 1.1 schema which will allow for ARP entry matching, as the 32 bit version of Acrobat Reader and the 64 bit version of Acrobat Reader have different ARP data.
winget validate --manifest <path>
?winget install --manifest <path>
?Note:
<path>
is the name of the directory containing the manifest you're submitting.Closes #32785
Microsoft Reviewers: Open in CodeFlow