Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Adobe.Acrobat.Reader.64-Bit v21.007.20099 #33539

Merged
3 commits merged into from
Nov 1, 2021

Conversation

Trenly
Copy link
Contributor

@Trenly Trenly commented Nov 1, 2021

I specifically chose the package identifier to allow for Adobe.Acrobat.Pro to be added later.
This is required to be separate from the 32-bit version until the 1.1 schema which will allow for ARP entry matching, as the 32 bit version of Acrobat Reader and the 64 bit version of Acrobat Reader have different ARP data.

  • Have you signed the Contributor License Agreement?
  • Have you checked that there aren't other open pull requests for the same manifest update/change?
  • Have you validated your manifest locally with winget validate --manifest <path>?
  • Have you tested your manifest locally with winget install --manifest <path>?
  • Does your manifest conform to the 1.0 schema?

Note: <path> is the name of the directory containing the manifest you're submitting.


Closes #32785

Microsoft Reviewers: Open in CodeFlow

@wingetbot
Copy link
Collaborator

Service Badge  Service Badge  

@wingetbot
Copy link
Collaborator

/AzurePipelines run

@azure-pipelines
Copy link

Azure Pipelines successfully started running 1 pipeline(s).

@ghost ghost added the Moderator-Approved One of the Moderators has reviewed and approved this PR label Nov 1, 2021
CopyrightUrl: https://www.adobe.com/content/dam/cc/en/legal/licenses-terms/pdf/Reader-EULA-en_US-20181207.pdf
ShortDescription: The free global standard for reliably viewing, printing, signing, and commenting on PDF documents.
Description: Adobe Acrobat Reader DC software is the free, trusted global standard for viewing, printing, signing, sharing, and annotating PDFs. It's the only PDF viewer that can open and interact with all types of PDF content – including forms and multimedia.
Moniker: acrobatreader
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
Moniker: acrobatreader
Moniker: adobe-reader

People usually refer to this app in speech as Adobe Reader. Unless someone has an objection, the moniker should probably be changed.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I was simply going with what was originally in the 32-bit version; I don't have an objection to changing it, but addiitonal opinions would be appreciated

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We shouldn't have a moniker pointing to two different PackageIdentifiers, that means you can't use it to install the package. So maybe adobe-reader-x64?

@ghost ghost added Needs-Author-Feedback This needs a response from the author. Needs-Attention This work item needs to be reviewed by a member of the core team. and removed Needs-Author-Feedback This needs a response from the author. labels Nov 1, 2021
@wingetbot wingetbot added Azure-Pipeline-Passed Validation pipeline passed. There may still be manual validation requirements. Validation-Completed Validation passed labels Nov 1, 2021
@ghost
Copy link

ghost commented Nov 1, 2021

Hello @wingetbot!

Because this pull request has the Validation-Completed label, I will be glad to assist with helping to merge this pull request once all check-in policies pass.

p.s. you can customize the way I help with merging this pull request, such as holding this pull request until a specific person approves. Simply @mention me (@msftbot) and give me an instruction to get started! Learn more here.

@ghost
Copy link

ghost commented Nov 1, 2021

Hello @Trenly,
Validation has completed.

@ghost ghost merged commit f60be30 into microsoft:master Nov 1, 2021
@Trenly Trenly deleted the Adobe.Acrobat.Reader.64-bit branch November 1, 2021 19:35
@wingetbot
Copy link
Collaborator

Publish pipeline succeeded for this Pull Request. Once you refresh your index, this change should be present.

@denelon
Copy link
Contributor

denelon commented Nov 1, 2021

I have microsoft/winget-cli#906 in the backlog to support specifying architecture settings/preferences. I believe we default to the "best" architecture for the available installers. I'm not sure there is a reason to have a separate package.

This pull request was closed.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Azure-Pipeline-Passed Validation pipeline passed. There may still be manual validation requirements. Moderator-Approved One of the Moderators has reviewed and approved this PR Needs-Attention This work item needs to be reviewed by a member of the core team. Validation-Completed Validation passed
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Package Request]:
5 participants