Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Mozilla.Firefox-msix version 94.0.0.0 #34087

Conversation

oxygen-dioxide
Copy link
Contributor

@oxygen-dioxide oxygen-dioxide commented Nov 5, 2021

  • Have you signed the Contributor License Agreement?
  • Have you checked that there aren't other open pull requests for the same manifest update/change?
  • Have you validated your manifest locally with winget validate --manifest <path>?
  • Have you tested your manifest locally with winget install --manifest <path>?
  • Does your manifest conform to the 1.0 schema?

Note: <path> is the name of the directory containing the manifest you're submitting.


Microsoft Reviewers: Open in CodeFlow

@wingetbot
Copy link
Collaborator

Service Badge  Service Badge  

@wingetbot
Copy link
Collaborator

/AzurePipelines run

@azure-pipelines
Copy link

Azure Pipelines successfully started running 1 pipeline(s).

Copy link
Contributor

@jedieaston jedieaston left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why can't this just be part of the Mozilla.Firefox manifest?

@ghost ghost added the Needs-Author-Feedback This needs a response from the author. label Nov 5, 2021
@ghost ghost added the Needs-Attention This work item needs to be reviewed by a member of the core team. label Nov 5, 2021
@ghost ghost assigned ChuckFerring-zz Nov 5, 2021
@oxygen-dioxide
Copy link
Contributor Author

Why can't this just be part of the Mozilla.Firefox manifest?

The version number format of this msix package is different from the Mozilla.Firefox manifest. For example, Mozilla.Firefox 94.0 is Mozilla.Firefox-msix 94.0.0.0

@ghost ghost removed the Needs-Author-Feedback This needs a response from the author. label Nov 5, 2021
@jedieaston
Copy link
Contributor

That's true, but due to Firefox's versioning scheme it shouldn't matter in practice (they only use to the second decimal point for any release), it shouldn't matter (94.0.0.0 would upgrade to 94.0.1 in winget's logic).

@OfficialEsco
Copy link
Contributor

That's true, but due to Firefox's versioning scheme it shouldn't matter in practice (they only use to the second decimal point for any release), it shouldn't matter (94.0.0.0 would upgrade to 94.0.1 in winget's logic).

WinGet also "ignore"/remove zero's, so if we flipped the numbers 94.0.0.0 would not show up as a upgrade for version 94.0 (Its just good practice to keep the 0's if the versions are the same)
This can also be corrected in Manifest Version 1.1 with ease since the msix dosn't break winget

@oxygen-dioxide
Copy link
Contributor Author

#34147

@oxygen-dioxide
Copy link
Contributor Author

oxygen-dioxide commented Nov 6, 2021

Why can't this just be part of the Mozilla.Firefox manifest?

Then how can I choose which package to install between the exe package and the msix package?

Copy link
Contributor

@ItzLevvie ItzLevvie left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Added in #34147?

@ghost ghost added the Needs-Author-Feedback This needs a response from the author. label Nov 6, 2021
@ghost ghost mentioned this pull request Nov 6, 2021
@ghost ghost closed this in #34173 Nov 6, 2021
This pull request was closed.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Needs-Attention This work item needs to be reviewed by a member of the core team. Needs-Author-Feedback This needs a response from the author. Validation-Executable-Error
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants