Installer Detection Enhancements #35735
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* Begin update in place * Condense installer switch logic * Fix Null values * Prevent null checking * Cleanup * Fix missed variable * Bump version * Update function calls * Fix empty ProductCode * Confirm Architecture when Automatically Detected * Remove Debug Line * Add duplicate url check for Quick update * Remove line used in debugging
|
|
vedantmgoyal9
suggested changes
Nov 22, 2021
ghost
added
Needs-Author-Feedback
vedantmgoyal9
previously approved these changes
Nov 22, 2021
OfficialEsco
previously approved these changes
Nov 22, 2021
ghost
added
the
Moderator-Approved
vedantmgoyal9
added a commit
to vedantmgoyal9/vedantmgoyal9
that referenced
this pull request
Nov 23, 2021
* Updated to v1.1.0 manifests * Correct Null Checks * When Installer URL is the same for multiple entries, skip re-downloading
Trenly
dismissed stale reviews from OfficialEsco and vedantmgoyal9
via
3f29e4a
ghost
removed
Needs-Attention
vedantmgoyal9
approved these changes
Nov 24, 2021
denelon
approved these changes
Nov 30, 2021
ghost
added
the
Moderator-Approved
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Microsoft Reviewers: Open in CodeFlow