Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix Scope for SumatraPDF.SumatraPDF version 3.2 #46366

Merged
1 commit merged into from Feb 16, 2022
Merged

Fix Scope for SumatraPDF.SumatraPDF version 3.2 #46366

1 commit merged into from Feb 16, 2022

Conversation

ghost
Copy link

@ghost ghost commented Feb 15, 2022

Reverts an experiment I did with this package back when REST API was in its experimental stages to play around with the upgrade mechanism.

See microsoft/winget-cli#1583 (comment). This may or may not fix the upgrade issue (from 3.3 (user) to 3.3.3 (user)) but it's worth a try:
image

Thanks to @ImJoakim for fixing it in the latest packages.

  • Have you signed the Contributor License Agreement?
  • Have you checked that there aren't other open pull requests for the same manifest update/change?
  • Have you validated your manifest locally with winget validate --manifest <path>?
  • Have you tested your manifest locally with winget install --manifest <path>?
  • Does your manifest conform to the 1.0 schema?

Note: <path> is the name of the directory containing the manifest you're submitting.


Microsoft Reviewers: Open in CodeFlow

Reverts an experiment I did with this package back when REST API was in its experimental stages.

Thanks to @ImJoakim for fixing it in the latest packages.
@wingetbot
Copy link
Collaborator

Service Badge  Service Badge  

@wingetbot
Copy link
Collaborator

/AzurePipelines run

@azure-pipelines
Copy link

Azure Pipelines successfully started running 1 pipeline(s).

@ghost ghost added the Moderator-Approved One of the Moderators has reviewed and approved this PR label Feb 15, 2022
@wingetbot wingetbot added Azure-Pipeline-Passed Validation pipeline passed. There may still be manual validation requirements. Validation-Domain Needs-Attention This work item needs to be reviewed by a member of the core team. labels Feb 15, 2022
@ghost ghost assigned zachcarp and florelis Feb 15, 2022
@ghost
Copy link

ghost commented Feb 15, 2022

@itzlevvie2,

One or more of the installer URLs doesn't appear valid.

This may happen for sites with policies prohibiting distribution or use by third parties.

This may happen for URLs pointing to domains that do not align with the publisher domain or package domain. If you could provide supporting evidence from the publisher that the URLs for the installer are correct, that would help us to validate and approve this PR.

@ghost ghost added Needs-Author-Feedback This needs a response from the author. and removed Needs-Author-Feedback This needs a response from the author. labels Feb 15, 2022
@zachcarp
Copy link
Contributor

@wingetbot waivers Add Validation-Domain

@wingetbot
Copy link
Collaborator

/AzurePipelines run

@ghost ghost removed Validation-Domain Needs-Attention This work item needs to be reviewed by a member of the core team. Azure-Pipeline-Passed Validation pipeline passed. There may still be manual validation requirements. labels Feb 16, 2022
@azure-pipelines
Copy link

Azure Pipelines successfully started running 1 pipeline(s).

@wingetbot wingetbot added Azure-Pipeline-Passed Validation pipeline passed. There may still be manual validation requirements. Validation-Completed Validation passed labels Feb 16, 2022
@ghost
Copy link

ghost commented Feb 16, 2022

Hello @wingetbot!

Because this pull request has the Validation-Completed label, I will be glad to assist with helping to merge this pull request once all check-in policies pass.

p.s. you can customize the way I help with merging this pull request, such as holding this pull request until a specific person approves. Simply @mention me (@msftbot) and give me an instruction to get started! Learn more here.

@ghost
Copy link

ghost commented Feb 16, 2022

Hello @itzlevvie2,
Validation has completed.

@ghost ghost merged commit 77b2eea into microsoft:master Feb 16, 2022
@wingetbot
Copy link
Collaborator

Publish pipeline succeeded for this Pull Request. Once you refresh your index, this change should be present.

This pull request was closed.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Azure-Pipeline-Passed Validation pipeline passed. There may still be manual validation requirements. Moderator-Approved One of the Moderators has reviewed and approved this PR Validation-Completed Validation passed Waived-Validation-Domain
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants