Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Saleae.Logic version 2.3.47 #56840

Conversation

chausner
Copy link
Contributor

@chausner chausner commented Apr 5, 2022

  • Have you signed the Contributor License Agreement?
  • Have you checked that there aren't other open pull requests for the same manifest update/change?
  • Have you validated your manifest locally with winget validate --manifest <path>?
  • Have you tested your manifest locally with winget install --manifest <path>?
  • Does your manifest conform to the 1.1 schema?

Note: <path> is the name of the directory containing the manifest you're submitting.


Microsoft Reviewers: Open in CodeFlow

@wingetbot
Copy link
Collaborator

Service Badge  Service Badge  

@wingetbot
Copy link
Collaborator

/AzurePipelines run

@azure-pipelines
Copy link

Azure Pipelines successfully started running 1 pipeline(s).

@wingetbot wingetbot added the Validation-Unattended-Failed During installation testing the installer was blocked on user input and no switches were provided. label Apr 5, 2022
Copy link
Contributor

@Trenly Trenly left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

image

@ghost ghost added the Needs-Author-Feedback This needs a response from the author. label Apr 5, 2022
@ghost ghost removed the Needs-Author-Feedback This needs a response from the author. label Apr 5, 2022
@chausner
Copy link
Contributor Author

chausner commented Apr 5, 2022

Blocked by microsoft/winget-cli#684.

@Trenly
Copy link
Contributor

Trenly commented Apr 5, 2022

Blocked by microsoft/winget-cli#684.

I think that issue is something else entirely, since the drivers are packaged as part of the application here, they just need the permission to install. This is more of an Interactive-Only-Installer thing. I forget the issue number, but I think if @denelon tags this issue, wingetbot might know

@ghost
Copy link

ghost commented Apr 5, 2022

@chausner,

This package appears to require user interaction to install.

This PR is blocked until support for interactive installer search filtering is implemented in:

@ghost ghost added the Blocking-Issue Manifest validation is blocked by a known issue. label Apr 5, 2022
@ghost ghost added the Moderator-Approved One of the Moderators has reviewed and approved this PR label May 2, 2022
@microsoft-github-policy-service microsoft-github-policy-service bot added the No-Recent-Activity No activity has occurred on this work item for seven days. label Dec 7, 2023
Copy link
Contributor

Hello @chausner,

This pull request has been automatically marked as stale because it has been marked as requiring author feedback but has not had any activity for 7 days. It will be closed if no further activity occurs within 7 days of this comment.

Template: msftbot/noRecentActivity

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Blocking-Issue Manifest validation is blocked by a known issue. Interactive-Only-Installer Moderator-Approved One of the Moderators has reviewed and approved this PR No-Recent-Activity No activity has occurred on this work item for seven days. Validation-Unattended-Failed During installation testing the installer was blocked on user input and no switches were provided.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants