Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

ViGEm.BthPS3 version 2.1.153.0 #65544

Closed
wants to merge 2 commits into from
Closed

ViGEm.BthPS3 version 2.1.153.0 #65544

wants to merge 2 commits into from

Conversation

sitiom
Copy link
Contributor

@sitiom sitiom commented Jul 9, 2022 •
edited
Loading

  • Have you signed the Contributor License Agreement?
  • Have you checked that there aren't other open pull requests for the same manifest update/change?
  • Have you validated your manifest locally with winget validate --manifest <path>?
  • Have you tested your manifest locally with winget install --manifest <path>?
  • Does your manifest conform to the 1.1 schema?

Note: <path> is the name of the directory containing the manifest you're submitting.

Microsoft Reviewers: Open in CodeFlow

@wingetbot
Copy link
Collaborator

Service Badge  Service Badge  

@wingetbot
Copy link
Collaborator

/AzurePipelines run

@azure-pipelines
Copy link

Azure Pipelines successfully started running 1 pipeline(s).

@sitiom sitiom mentioned this pull request Mar 16, 2024
Open
@wingetbot wingetbot added the Validation-Installation-Error Error installing application label Jul 9, 2022
@ghost
Copy link

ghost commented Jul 9, 2022

Hello @sitiom,
The package manager bot determined there was an issue with installing the application correctly. Please check the application installs correctly. Once repaired, please push an update to your pull request.

@ghost ghost added Needs-Author-Feedback This needs a response from the author. Needs-Attention This work item needs to be reviewed by a member of the core team. and removed Needs-Author-Feedback This needs a response from the author. labels Jul 9, 2022
@wingetbot
Copy link
Collaborator

/AzurePipelines run

@ghost ghost removed Validation-Installation-Error Error installing application Needs-Attention This work item needs to be reviewed by a member of the core team. labels Jul 10, 2022
@azure-pipelines
Copy link

Azure Pipelines successfully started running 1 pipeline(s).

@wingetbot wingetbot added the Manifest-Validation-Error Manifest validation failed label Jul 10, 2022
@ghost
Copy link

ghost commented Jul 10, 2022

Hello @sitiom,
The package manager bot determined that the metadata was not compliant.

Please verify the manifest file is compliant with the package manager 1.0 manifest specification.
Make sure the ID is of the form publisher.appname and that the folder structure is manifests\partition\publisher\appname\version.
Note: The path and "PackageIdentifier" are case sensitive.
Be sure to use a tool like VSCode (https://code.visualstudio.com/) to make sure the manifest YAML syntax is correct.

You could also try our Windows Package Manager Manifest Creator Preview.

For details on the specific error, see the details link below in the build pipeline.

@ghost ghost added the Needs-Author-Feedback This needs a response from the author. label Jul 10, 2022
@sitiom sitiom force-pushed the autogenerated/ViGEm.BthPS3/5cb6f8ea-03eb-463f-851e-be7870c67435 branch from 6301394 to 52c6ba6 Compare July 10, 2022 03:17
@ghost ghost removed Manifest-Validation-Error Manifest validation failed Needs-Author-Feedback This needs a response from the author. labels Jul 10, 2022
@wingetbot
Copy link
Collaborator

/AzurePipelines run

@azure-pipelines
Copy link

Azure Pipelines successfully started running 1 pipeline(s).

@wingetbot wingetbot added the Validation-Installation-Error Error installing application label Jul 10, 2022
@ghost
Copy link

ghost commented Jul 10, 2022

Hello @sitiom,
The package manager bot determined there was an issue with installing the application correctly. Please check the application installs correctly. Once repaired, please push an update to your pull request.

@ghost ghost added the Needs-Author-Feedback This needs a response from the author. label Jul 10, 2022
@sitiom
Copy link
Contributor Author

sitiom commented Jul 10, 2022 •
edited
Loading

Test in the Sandbox. Requires Bluetooth stack:
image

I have to guess there is a Blocking-Issue here.

@ghost ghost added Needs-Attention This work item needs to be reviewed by a member of the core team. and removed Needs-Author-Feedback This needs a response from the author. labels Jul 10, 2022
@ghost ghost added the Moderator-Approved One of the Moderators has reviewed and approved this PR label Jul 10, 2022
ItzLevvie
ItzLevvie suggested changes Jul 31, 2022
View reviewed changes
Copy link
Contributor

@ItzLevvie ItzLevvie left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

#65544 (comment)

You can set this PR to DRAFT until Bluetooth stack is available in validation pipelines (probably requires custom hardware)

@ghost ghost added the Needs-Author-Feedback This needs a response from the author. label Jul 31, 2022
@ghost ghost assigned sitiom Jul 31, 2022
@ghost
Copy link

ghost commented Jul 31, 2022

Hello @sitiom,
The package manager bot determined changes have been requested to your PR.

Template: msftbot/changesRequested

@sitiom sitiom marked this pull request as draft July 31, 2022 00:21
@ghost ghost removed the Needs-Author-Feedback This needs a response from the author. label Jul 31, 2022
@sitiom
Copy link
Contributor Author

sitiom commented Jul 31, 2022 •
edited
Loading

@denelon denelon removed the Needs-Attention This work item needs to be reviewed by a member of the core team. label Aug 23, 2022
@ItzLevvie
Copy link
Contributor

@msftbot Blocking-Issue

@ghost ghost added Needs-Author-Feedback This needs a response from the author. Blocking-Issue Manifest validation is blocked by a known issue. Needs-Attention This work item needs to be reviewed by a member of the core team. and removed Needs-Author-Feedback This needs a response from the author. labels Nov 9, 2022
@stephengillie
Copy link
Collaborator

/AzurePipelines run

@azure-pipelines Azure Pipelines
Copy link

Azure Pipelines successfully started running 1 pipeline(s).

@microsoft-github-policy-service microsoft-github-policy-service bot removed Validation-Installation-Error Error installing application Blocking-Issue Manifest validation is blocked by a known issue. Needs-Attention This work item needs to be reviewed by a member of the core team. labels Dec 15, 2023
@microsoft-github-policy-service microsoft-github-policy-service bot added Needs-Author-Feedback This needs a response from the author. No-Recent-Activity No activity has occurred on this work item for seven days. labels Dec 15, 2023
@microsoft-github-policy-service Microsoft GitHub Policy Service
Copy link
Contributor

Hello @sitiom,

This pull request has been automatically marked as stale because it has been marked as requiring author feedback but has not had any recent activity. It will be closed if no further activity occurs within 3 days of this comment.

Template: msftbot/noRecentActivity

@sitiom sitiom deleted the autogenerated/ViGEm.BthPS3/5cb6f8ea-03eb-463f-851e-be7870c67435 branch December 24, 2023 15:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ItzLevvie ItzLevvie ItzLevvie requested changes

Assignees

@sitiom sitiom

Labels
Moderator-Approved One of the Moderators has reviewed and approved this PR Needs-Author-Feedback This needs a response from the author. No-Recent-Activity No activity has occurred on this work item for seven days. Validation-Shell-Execute
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@sitiom @wingetbot @ItzLevvie @stephengillie @denelon