Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update: Microsoft.WingetCreate version 1.1.2.0 #69431

Merged

Conversation

russellbanks
Copy link
Contributor

@russellbanks russellbanks commented Aug 11, 2022

  • Have you signed the Contributor License Agreement?
  • Have you checked that there aren't other open pull requests for the same manifest update/change?
  • Have you validated your manifest locally with winget validate --manifest <path>?
  • Have you tested your manifest locally with winget install --manifest <path>?
  • Does your manifest conform to the 1.1 schema?

This adds the portable wingetcreate exe

Microsoft Reviewers: Open in CodeFlow

@wingetbot
Copy link
Collaborator

Service Badge  Service Badge  

@wingetbot
Copy link
Collaborator

/AzurePipelines run

@azure-pipelines
Copy link

Azure Pipelines successfully started running 1 pipeline(s).

@wingetbot wingetbot added the Manifest-Validation-Error Manifest validation failed label Aug 11, 2022
@ghost
Copy link

ghost commented Aug 11, 2022

Hello @russellbanks,
The package manager bot determined that the metadata was not compliant.

Please verify the manifest file is compliant with the package manager 1.0 manifest specification.
Make sure the ID is of the form publisher.appname and that the folder structure is manifests\partition\publisher\appname\version.
Note: The path and "PackageIdentifier" are case sensitive.
Be sure to use a tool like VSCode (https://code.visualstudio.com/) to make sure the manifest YAML syntax is correct.

You could also try our Windows Package Manager Manifest Creator Preview.

For details on the specific error, see the details link below in the build pipeline.

Template: msftbot/validationError/manifest/metadata

@ghost ghost added the Needs-Author-Feedback This needs a response from the author. label Aug 11, 2022
ItzLevvie
ItzLevvie previously approved these changes Aug 11, 2022
@ghost ghost added the Moderator-Approved One of the Moderators has reviewed and approved this PR label Aug 11, 2022
@ghost ghost assigned russellbanks Aug 12, 2022
@ghost
Copy link

ghost commented Aug 12, 2022

Hello @russellbanks,
The package manager bot determined changes have been requested to your PR.

Template: msftbot/changesRequested

@Trenly
Copy link
Contributor

Trenly commented Aug 12, 2022

As I've been thinking. . . @ryfu-msft / @denelon - Given that this package is managed by the winget team, do you want the portable exe added here?

@denelon denelon removed the Moderator-Approved One of the Moderators has reviewed and approved this PR label Aug 12, 2022
@denelon
Copy link
Contributor

denelon commented Aug 12, 2022

I've been thinking about this one since we have the MSIX version and the portable versions with and without dependencies to support CI/CD flows. We don't have anything like winget install <package> --installer-type [MSIX, MSI, .exe, portable, zip]. This is likely to set a precedent so we should be intentional.

@denelon
Copy link
Contributor

denelon commented Aug 12, 2022

We should look at:

@russellbanks
Copy link
Contributor Author

It might make sense to have Microsoft.WingetCreate.Portable and break that down into the versions with and without dependencies. The manifest for the .exe without dependencies should declare them so if they are on the system they don't get downloaded.

Haven't the self-contained portable .exe's been removed since v1.1.2.0:

Note: Self-contained exes have been removed since WS2022 now supports AppExecutionAliases. Check out the README for instructions on how to use the msixbundle in your CI/CD pipeline.

@ghost ghost added Needs-Attention This work item needs to be reviewed by a member of the core team. and removed Needs-Author-Feedback This needs a response from the author. labels Aug 12, 2022
@ghost ghost removed Manifest-Validation-Error Manifest validation failed Needs-Attention This work item needs to be reviewed by a member of the core team. labels Aug 12, 2022
@wingetbot
Copy link
Collaborator

/AzurePipelines run

@azure-pipelines
Copy link

Azure Pipelines successfully started running 1 pipeline(s).

@wingetbot wingetbot added the Manifest-Validation-Error Manifest validation failed label Aug 12, 2022
@ghost
Copy link

ghost commented Aug 12, 2022

Hello @russellbanks,
The package manager bot determined that the metadata was not compliant.

Please verify the manifest file is compliant with the package manager 1.0 manifest specification.
Make sure the ID is of the form publisher.appname and that the folder structure is manifests\partition\publisher\appname\version.
Note: The path and "PackageIdentifier" are case sensitive.
Be sure to use a tool like VSCode (https://code.visualstudio.com/) to make sure the manifest YAML syntax is correct.

You could also try our Windows Package Manager Manifest Creator Preview.

For details on the specific error, see the details link below in the build pipeline.

Template: msftbot/validationError/manifest/metadata

@ghost ghost added the Needs-Author-Feedback This needs a response from the author. label Aug 12, 2022
@denelon
Copy link
Contributor

denelon commented Aug 12, 2022

I think I'm OK having both the MSIX and the portable .exe in the same manifest. It's going to take feature work to allow someone to install the portable though. It might be best in the short term to have a Microsoft.WingetCreate.Portable manifest for now so people can use winget to install the portable version.

@denelon
Copy link
Contributor

denelon commented Aug 12, 2022

@ryfu-msft let me know if you have a different opinion 😊

@ghost ghost added the Moderator-Approved One of the Moderators has reviewed and approved this PR label Aug 13, 2022
@Trenly
Copy link
Contributor

Trenly commented Aug 17, 2022

@wingetbot run

@wingetbot
Copy link
Collaborator

/AzurePipelines run

@azure-pipelines
Copy link

Azure Pipelines successfully started running 1 pipeline(s).

@ghost ghost removed Manifest-Validation-Error Manifest validation failed Needs-Author-Feedback This needs a response from the author. labels Aug 17, 2022
@wingetbot wingetbot added Azure-Pipeline-Passed Validation pipeline passed. There may still be manual validation requirements. Validation-Completed Validation passed labels Aug 17, 2022
@ghost
Copy link

ghost commented Aug 17, 2022

Hello @wingetbot!

Because this pull request has the Validation-Completed label, I will be glad to assist with helping to merge this pull request once all check-in policies pass.

p.s. you can customize the way I help with merging this pull request, such as holding this pull request until a specific person approves. Simply @mention me (@msftbot) and give me an instruction to get started! Learn more here.

@ghost
Copy link

ghost commented Aug 17, 2022

Hello russellbanks,
Validation has completed.

Template: msftbot/validationCompleted

@ghost ghost merged commit 357b4f6 into microsoft:master Aug 17, 2022
@russellbanks russellbanks deleted the Microsoft.WingetCreate-1.1.2.0-FE4704E0C53FB9 branch August 19, 2022 00:31
This pull request was closed.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Azure-Pipeline-Passed Validation pipeline passed. There may still be manual validation requirements. Moderator-Approved One of the Moderators has reviewed and approved this PR Validation-Completed Validation passed
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants