Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Olympus.Olympus version 21.01.11.07 #95906

Closed
wants to merge 7 commits into from
Closed

Olympus.Olympus version 21.01.11.07 #95906

wants to merge 7 commits into from

Conversation

lemonjacob
Copy link

@lemonjacob lemonjacob commented Feb 8, 2023 •
edited
Loading

  • Have you signed the Contributor License Agreement?
  • Have you checked that there aren't other open pull requests for the same manifest update/change?
  • Have you validated your manifest locally with winget validate --manifest <path>?
  • Have you tested your manifest locally with winget install --manifest <path>?
  • Does your manifest conform to the 1.4 schema?

Note: <path> is the name of the directory containing the manifest you're submitting.

Microsoft Reviewers: Open in CodeFlow

@wingetbot
Copy link
Collaborator

Service Badge  Service Badge  

@wingetbot
Copy link
Collaborator

/AzurePipelines run

@azure-pipelines
Copy link

Azure Pipelines successfully started running 1 pipeline(s).

@wingetbot wingetbot added Azure-Pipeline-Passed Validation pipeline passed. There may still be manual validation requirements. Validation-Completed Validation passed labels Feb 8, 2023
@Trenly
Copy link
Contributor

Trenly commented Feb 9, 2023

@lemonjacob - I'm not sure what happened, but anytime I try to check out the commit to test it, I get fatal: reference is not a tree: 028644f4fa8de97784ce4022c5af7cf9cd8adbf2. Is there any way you could try re-pushing to the branch?

@wingetbot
Copy link
Collaborator

/AzurePipelines run

@microsoft-github-policy-service microsoft-github-policy-service bot removed Validation-Completed Validation passed Azure-Pipeline-Passed Validation pipeline passed. There may still be manual validation requirements. labels Feb 10, 2023
@azure-pipelines
Copy link

Azure Pipelines successfully started running 1 pipeline(s).

auto-merge was automatically disabled February 10, 2023 02:58

Head branch was pushed to by a user without write access

@lemonjacob
Delete l
0714be2 
delete unnecessary file
@wingetbot
Copy link
Collaborator

/AzurePipelines run

@azure-pipelines
Copy link

Azure Pipelines successfully started running 1 pipeline(s).

@lemonjacob
Copy link
Author

@lemonjacob - I'm not sure what happened, but anytime I try to check out the commit to test it, I get fatal: reference is not a tree: 028644f4fa8de97784ce4022c5af7cf9cd8adbf2. Is there any way you could try re-pushing to the branch?

I think I fixed it

@Trenly
Copy link
Contributor

Trenly commented Feb 10, 2023

@lemonjacob - I'm not sure what happened, but anytime I try to check out the commit to test it, I get fatal: reference is not a tree: 028644f4fa8de97784ce4022c5af7cf9cd8adbf2. Is there any way you could try re-pushing to the branch?

I think I fixed it

Thanks! Looks like git is detecting it as a valid tree now, will test!

Trenly
Trenly suggested changes Feb 10, 2023
View reviewed changes
Copy link
Contributor

@Trenly Trenly left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

[Policy] Dependencies
@stephengillie / @denelon - Hardware too please

image

manifests/o/Olympus/Olympus/21.01.11.07/Olympus.Olympus.installer.yaml Outdated Show resolved Hide resolved
manifests/o/Olympus/Olympus/21.01.11.07/Olympus.Olympus.locale.en-US.yaml Outdated Show resolved Hide resolved
manifests/o/Olympus/Olympus/21.01.11.07/Olympus.Olympus.yaml Outdated Show resolved Hide resolved
manifests/o/Olympus/Olympus/21.01.11.07/Olympus.Olympus.installer.yaml Show resolved Hide resolved
@microsoft-github-policy-service
Copy link
Contributor

Hello @wingetbot,

The package manager bot determined there was an issue with one of the installers listed in the url field, and cannot continue.

The application included in this pull request failed to install during dynamic validation. This test is designed to ensure that the application installs on all environments without warnings. Please, verify that the application installs correctly on architectures specified in the manifest using winget cli.

Template: msftbot/validationError/installers/shellExecute

@microsoft-github-policy-service microsoft-github-policy-service bot added Needs-Author-Feedback This needs a response from the author. Dependencies Blocking-Issue Manifest validation is blocked by a known issue. and removed Needs-Author-Feedback This needs a response from the author. labels Feb 10, 2023
@microsoft-github-policy-service microsoft-github-policy-service bot removed the Needs-Author-Feedback This needs a response from the author. label Feb 10, 2023
@lemonjacob @Trenly
Update manifests/o/Olympus/Olympus/21.01.11.07/Olympus.Olympus.instal…
230207b 
…ler.yaml


Change to package name to match publishers name

Co-authored-by: Kaleb Luedtke <trenlymc@gmail.com>
@wingetbot
Copy link
Collaborator

/AzurePipelines run

@microsoft-github-policy-service microsoft-github-policy-service bot removed Blocking-Issue Manifest validation is blocked by a known issue. Validation-Shell-Execute labels Feb 10, 2023
@lemonjacob @Trenly
Update manifests/o/Olympus/Olympus/21.01.11.07/Olympus.Olympus.yaml
f63422a 
Change package name name to match publishers name

Co-authored-by: Kaleb Luedtke <trenlymc@gmail.com>
@azure-pipelines
Copy link

Azure Pipelines successfully started running 1 pipeline(s).

@wingetbot
Copy link
Collaborator

/AzurePipelines run

@azure-pipelines
Copy link

Azure Pipelines successfully started running 1 pipeline(s).

@lemonjacob @Trenly
Update manifests/o/Olympus/Olympus/21.01.11.07/Olympus.Olympus.locale…
30ea41d 
….en-US.yaml


Change package name to match publishers name

Co-authored-by: Kaleb Luedtke <trenlymc@gmail.com>
@wingetbot
Copy link
Collaborator

/AzurePipelines run

@azure-pipelines
Copy link

Azure Pipelines successfully started running 1 pipeline(s).

@wingetbot wingetbot added the Manifest-Validation-Error Manifest validation failed label Feb 10, 2023
@microsoft-github-policy-service
Copy link
Contributor

Hello @wingetbot,

The package manager bot determined that the metadata was not compliant.

Please verify the manifest file is compliant with the package manager 1.4 manifest specification.
Make sure the ID is of the form publisher.appname and that the folder structure is manifests\partition\publisher\appname\version.
Note: The path and "PackageIdentifier" are case sensitive.
Be sure to use a tool like VSCode to make sure the manifest YAML syntax is correct.

You could also try our Windows Package Manager Manifest Creator or the YamlCreate script.

For details on the specific error, see the details link below in the build pipeline.

Template: msftbot/validationError/manifest/metadata

@microsoft-github-policy-service microsoft-github-policy-service bot added the Needs-Author-Feedback This needs a response from the author. label Feb 10, 2023
@lemonjacob lemonjacob closed this Feb 10, 2023
@lemonjacob lemonjacob deleted the autogenerated/Olympus.Olympus/536fb890-2ec7-4799-b07b-8f9215067ea3 branch February 10, 2023 03:41
@denelon denelon added the Hardware Specific hardware is required to install or validate this package label Feb 10, 2023
@microsoft-github-policy-service
Copy link
Contributor

Hello @denelon,

This package appears to require specific hardware.

This PR is blocked until support for specific hardware requirements is implemented in:

Template: msftbot/blockingIssue/hardwareDependency

@microsoft-github-policy-service microsoft-github-policy-service bot added the Blocking-Issue Manifest validation is blocked by a known issue. label Feb 10, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Trenly Trenly Trenly requested changes

Assignees
No one assigned
Labels
Blocking-Issue Manifest validation is blocked by a known issue. Dependencies Hardware Specific hardware is required to install or validate this package Manifest-Validation-Error Manifest validation failed Needs-Author-Feedback This needs a response from the author.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@lemonjacob @wingetbot @Trenly @denelon