Handle single plane frames #101
Open
+2
−6
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jlautman
reviewed
Jan 5, 2021
| hr = bitmap_buffer->GetPlaneDescription(0, &bitmap_plane_description_y); | ||
| } | ||
|
|
||
| if (SUCCEEDED(hr)) { | ||
| if (SUCCEEDED(hr) && plane_count == 2) { |
There was a problem hiding this comment.
Previously, plane_count == 3 would have set hr to E_FAIL. Is there a guarantee that plane_count is never any value other than 0, 1, or 2?
There was a problem hiding this comment.
You're right. It probably makes sense to fail if plane_count isn't 1 or 2.
jlautman
reviewed
Jan 5, 2021
| } | ||
|
|
||
| if (SUCCEEDED(hr)) { | ||
| if (SUCCEEDED(hr) && plane_count >= 1) { |
There was a problem hiding this comment.
This change treats 1 plane and 2 plane frames identically. Is that intentional or is there any different work that needs to be done in the 1 plane case?
There was a problem hiding this comment.
It's intentional: pfn_incoming_frame_ is able to figure out the data format and to decode it correctly.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is meant to fix #86