This repository has been archived by the owner on Nov 16, 2023. It is now read-only.
SaveAs now changes the workbook title #501
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
slodge
requested review from
abock,
lewing and
sandyarmstrong
as code owners
|
|
|
As it mentions my "employer", I need to check with some legals on https://cla.opensource.microsoft.com/Microsoft/workbooks?pullRequest=501 (will be back Monday or Tuesday!) |
|
CLA now signed - so over to you - but enjoy your trip first 👍 |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This change improves the SaveAs behaviour for Xamarin workbooks addressing #189
I've tested this in Windows/WPF and it seems to work well. Sorry, I've not got a current Mac setup for Xamarin testing.