Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Minor bug fixes and release patch version v1.9.1 #239

Merged
merged 9 commits into from
Jun 6, 2024
Merged

Conversation

sachinstl
Copy link
Member

@sachinstl sachinstl commented May 30, 2024

Summary

This branch fixes issues #236, #237, #238 and prepares the patch version v1.9.1 for CRAN release.

Changes

The changes made in this PR are:

  1. Improvement: We can remove x-axis label in this special case, where hrvar is set to NULL. Issue in the create_boxplot when hrvar is set to NULL #236
  2. Improvement: Change the plot title according to the metric when metric has single value. Issue in create_stacked when metrics set to one metric then as well it shows collaboration hours  #237
  3. Improvement: We can add input validation to ensure the data is a data frame, predictors are columns in the data, and outcome is a binary variable in the data. Issue in create_IV : function doesn't validate the inputs #238

Checks

  • All R CMD checks pass
  • roxygen2::roxygenise() has been run prior to merging to ensure that .Rd and NAMESPACE files are up to date.
  • NEWS.md has been updated.

Notes

This fixes #236, #237, #238

Incorporated changes:

  1. After fix on bug Issue in the create_boxplot when hrvar is set to NULL #236:
create_boxplot(sq_data, metric = "Collaboration_hours", hrvar = NULL, return = "plot")

image

  1. After fix on bug Issue in create_stacked when metrics set to one metric then as well it shows collaboration hours  #237
sq_data %>% 
  create_stacked(hrvar = "FunctionType", 
                 metrics = "Meeting_hours", 
                 return = "plot" 
                 ) 

image

  1. After fix on bug Issue in create_IV : function doesn't validate the inputs #238
sq_data %>%
     create_stacked(hrvar = "FunctionType",
                    metrics = c("Meeting_hours"
                                ),
                    return = "plot",
                    plot_title = "Collaboration Hours",
                    rank = "ascending")

image

@martinctc
Copy link
Member

v1.9.1 has been accepted into CRAN, now merging this PR. Thanks for the changes @sachinstl!

@martinctc martinctc merged commit e3624fd into main Jun 6, 2024
3 checks passed
@martinctc martinctc deleted the patch-v1.9.1 branch June 6, 2024 15:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
2 participants