Metadata for Structs #401
Merged
Metadata for Structs #401
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Make fields private, introduce new type system to allow pointers to types being referenced, add new constructors to represent specific cases, and reorganize classes.
Include const and noexcept modifiers where appropriate.
Add model_ref class to generalize refs. Also, split up members vector in interfaces and classes to three vectors for properties, methods, and events.
Move implementations from cpp files to headers so that auto return types can resolve using just the header.
…ft/xlang into kythant/StructMetadata
kythant
requested review from
BenJKuhn,
DefaultRyan,
devhawk,
kennykerr and
Scottj1s
as code owners
Closed
BenJKuhn
reviewed
May 15, 2019
BenJKuhn
reviewed
May 15, 2019
BenJKuhn
reviewed
May 15, 2019
BenJKuhn
reviewed
May 15, 2019
BenJKuhn
reviewed
May 15, 2019
BenJKuhn
reviewed
May 15, 2019
BenJKuhn
reviewed
May 15, 2019
BenJKuhn
approved these changes
May 15, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR includes the emitting of metadata for structs and the tests for it.
Also includes major refactoring of the meta_idl_reader where I offloaded the push and pop stack logic to the ast_to_st_listener. I also added a xlang_error.h which in the future will be where we will report and store all the syntax and semantic errors that occurs.