Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Declaring Non-Nullable Parameters #708

Closed
wants to merge 2 commits into from
Closed

Declaring Non-Nullable Parameters #708

wants to merge 2 commits into from

Conversation

kennykerr
Copy link
Contributor

This is a description of the NotNull attribute. Subsequent work includes:

  • Updating the WinRT metadata to include the new attribute and adding MIDLRT tests for it.
  • Updating C#/WinRT to apply the new attribute
  • Updating Rust/WinRT to apply the new attribute

@Marv51
Copy link

Marv51 commented May 25, 2021

Hi everyone, may I ask what happened to this pull request? Looks like it was approved by three people and then closed without merging?
@kennykerr?

@kennykerr
Copy link
Contributor Author

I think it was deemed impractical to go back and annotate the many existing APIs that are known to be non-null. I have since come up with a solution for Rust that lets me deal with nullable parameters elegantly, so I no longer have a pressing need for this.

@dotMorten
Copy link

I have since come up with a solution for Rust that lets me deal with nullable parameters elegantly

@kennykerr but what about C#? We still have a pressing need for this.

it was deemed impractical to go back and annotate the many existing API

Impractical or a lot of work? Doing it for .NET was impractical and a lot of work, but it was done.

@kennykerr
Copy link
Contributor Author

Those things, and somebody actually needs to do the work. 😜 It's just a considerable amount of work across a much larger code base by not one but many disparate teams who are no longer actively maintaining many of those APIs.

@dlech
Copy link
Contributor

dlech commented Feb 23, 2023

Could the work be automated (e.g. with static analysis to detect nullability)? Could someone external to Microsoft do the work?

@kennykerr
Copy link
Contributor Author

No, but you can apply here: https://careers.microsoft.com/ 😉

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

7 participants