-
Notifications
You must be signed in to change notification settings - Fork 103
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Declaring Non-Nullable Parameters #708
Conversation
Hi everyone, may I ask what happened to this pull request? Looks like it was approved by three people and then closed without merging? |
I think it was deemed impractical to go back and annotate the many existing APIs that are known to be non-null. I have since come up with a solution for Rust that lets me deal with nullable parameters elegantly, so I no longer have a pressing need for this. |
@kennykerr but what about C#? We still have a pressing need for this.
Impractical or a lot of work? Doing it for .NET was impractical and a lot of work, but it was done. |
Those things, and somebody actually needs to do the work. 😜 It's just a considerable amount of work across a much larger code base by not one but many disparate teams who are no longer actively maintaining many of those APIs. |
Could the work be automated (e.g. with static analysis to detect nullability)? Could someone external to Microsoft do the work? |
No, but you can apply here: https://careers.microsoft.com/ 😉 |
This is a description of the
NotNull
attribute. Subsequent work includes: