This repository was archived by the owner on Jul 15, 2023. It is now read-only.
Update xUnit and CommandLineParser NuGet packages to stable versions #257
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@alexanderkozlenko There are not benchmark results with these changes. This is from the logs: simpleharness.exe | Metric | Unit | Iterations | Average | STDEV.S | Min | Max
:----------------- |:------ |:----:|:----------:| -------:| -------:| ---:| ---:Could you please take a look? |
|
Fixed with b6e3d0c |
jorive
reviewed
Jan 16, 2018
| base.Dispose(); | ||
| } | ||
|
|
||
| public ManualResetEvent Finished => _finished; |
There was a problem hiding this comment.
Could you please remove the private member variable _finished, and use property instead (like the Test property above):
...
public PerformanceTestMessageSink()
{
Finished = new ManualResetEvent(false);
Tests = new List<PerformanceTestMessage>();
...
public ManualResetEvent Finished { get; }
jorive
approved these changes
Jan 16, 2018
brianrob
added a commit
to brianrob/xunit-performance
that referenced
this pull request
Feb 22, 2018
…ersions (microsoft#257)" This reverts commit 03e7799.
ViktorHofer
added a commit
to ViktorHofer/xunit-performance
that referenced
this pull request
Jul 19, 2018
…stable versions (microsoft#257)" (microsoft#262)" This reverts commit 7f538aa.
jorive
pushed a commit
that referenced
this pull request
Jul 21, 2018
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.