[Modularize] Get-EntraDeletedServicePrincipal #1281
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Related PR - #1231 |
|
Learn Build status updates of commit 56ea848: ✅ Validation status: passed
For more details, please refer to the build report. For any questions, please:
|
KenitoInc
reviewed
Jan 20, 2025
| [<CommonParameters>] | ||
| ``` | ||
|
|
||
| ### GetByValue |
There was a problem hiding this comment.
I think this should be GetVague. Check the ps1 files
| [<CommonParameters>] | ||
| ``` | ||
|
|
||
| ### GetByValue |
There was a problem hiding this comment.
I think this should be GetVague. Check the ps1 files
| Mock -CommandName Get-MgDirectoryDeletedItemAsServicePrincipal -MockWith $scriptblock -ModuleName Microsoft.Entra.Applications | ||
| } | ||
|
|
||
| Describe "Get-EntraDeletedServicePrincipal" { |
There was a problem hiding this comment.
Add this test and check if it will work
It "Should contain 'PageSize' parameter" {
$result = Get-EntraDeletedServicePrincipal -All
$result | Should -Not -BeNullOrEmpty
Should -Invoke -CommandName Get-MgDirectoryDeletedItemAsServicePrincipal -ModuleName Microsoft.Entra.Applications -Times 1 -ParameterFilter {
$PageSize | Should -Be 999
$trueThere was a problem hiding this comment.
Also add to the beta tests
There was a problem hiding this comment.
Test added.
|
Learn Build status updates of commit b3eb842: ✅ Validation status: passed
For more details, please refer to the build report. For any questions, please:
|
|
Learn Build status updates of commit fce286f: ✅ Validation status: passed
For more details, please refer to the build report. For any questions, please:
|
KenitoInc
approved these changes
Jan 21, 2025
KenitoInc
pushed a commit
that referenced
this pull request
Jan 31, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Get-EntraDeletedServicePrincipal and Get-EntraBetaDeletedServicePrincipal