Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bump Serilog.Sinks.ApplicationInsights from 3.1.0 to 4.0.0 #1046

Merged

Conversation

dependabot[bot]
Copy link
Contributor

@dependabot dependabot bot commented on behalf of github Jun 23, 2022

Bumps Serilog.Sinks.ApplicationInsights from 3.1.0 to 4.0.0.

Release notes

Sourced from Serilog.Sinks.ApplicationInsights's releases.

v4.0.0

Breaking changes

To migrate, change any references to instrumentationKey to connectionString instead (including in JSON configuration). Discussion in #163.

Other changes

Thanks

Extra thanks to everyone who contributed to this release! It's been a rather drawn-out and awkward one, with a lot of changes sitting on dev for an extended period of time while we figured out the way forwards (and thanks also to everyone who had input into that!).

Commits
  • 34c144a Merge pull request #199 from serilog-contrib/dev
  • 624f1ab Merge pull request #198 from nblumhardt/pack-command-line
  • a12afd3 Fix version suffixing in build script
  • 5e00be6 Merge pull request #192 from serilog-contrib/dev
  • 1432667 README updates
  • 6871724 Merge branch 'zyofeng-use-connection-string' into dev
  • 575b344 switch to using connection string
  • db84721 Merge pull request #193 from zyofeng/azure-function-readme-update
  • 2c88e58 updated copyright disclaimer
  • b3ed775 updated readme.md to clarify Azure Functions usage
  • Additional commits viewable in compare view

Dependabot compatibility score

Dependabot will resolve any conflicts with this PR as long as you don't alter it yourself. You can also trigger a rebase manually by commenting @dependabot rebase.


Dependabot commands and options

You can trigger Dependabot actions by commenting on this PR:

  • @dependabot rebase will rebase this PR
  • @dependabot recreate will recreate this PR, overwriting any edits that have been made to it
  • @dependabot merge will merge this PR after your CI passes on it
  • @dependabot squash and merge will squash and merge this PR after your CI passes on it
  • @dependabot cancel merge will cancel a previously requested merge and block automerging
  • @dependabot reopen will reopen this PR if it is closed
  • @dependabot close will close this PR and stop Dependabot recreating it. You can achieve the same result by closing it manually
  • @dependabot ignore this major version will close this PR and stop Dependabot creating any more for this major version (unless you reopen the PR or upgrade to it yourself)
  • @dependabot ignore this minor version will close this PR and stop Dependabot creating any more for this minor version (unless you reopen the PR or upgrade to it yourself)
  • @dependabot ignore this dependency will close this PR and stop Dependabot creating any more for this dependency (unless you reopen the PR or upgrade to it yourself)

Bumps [Serilog.Sinks.ApplicationInsights](https://github.com/serilog-contrib/serilog-sinks-applicationinsights) from 3.1.0 to 4.0.0.
- [Release notes](https://github.com/serilog-contrib/serilog-sinks-applicationinsights/releases)
- [Commits](serilog-contrib/serilog-sinks-applicationinsights@v3.1.0...v4.0.0)

---
updated-dependencies:
- dependency-name: Serilog.Sinks.ApplicationInsights
  dependency-type: direct:production
  update-type: version-update:semver-major
...

Signed-off-by: dependabot[bot] <support@github.com>
@dependabot dependabot bot added .NET Pull requests that update .net code dependencies Pull requests that update a dependency file labels Jun 23, 2022
@baywet
Copy link
Member

baywet commented Jun 23, 2022

@MaggieKimani1 could you validate the configuration changes if any is needed because of the breaking change please?

@MaggieKimani1
Copy link
Contributor

MaggieKimani1 commented Jul 10, 2022

@MaggieKimani1 could you validate the configuration changes if any is needed because of the breaking change please?

Let me look into it...

@MaggieKimani1
Copy link
Contributor

MaggieKimani1 commented Jul 12, 2022

@MaggieKimani1 could you validate the configuration changes if any is needed because of the breaking change please?

Let me look into it...

@baywet Just validated this change and confirmed that we have the connection string already configured in our app service so there would be no side effects. Let's merge this.

@MaggieKimani1 MaggieKimani1 merged commit e803355 into dev Jul 12, 2022
@MaggieKimani1 MaggieKimani1 deleted the dependabot/nuget/Serilog.Sinks.ApplicationInsights-4.0.0 branch July 12, 2022 12:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
dependencies Pull requests that update a dependency file .NET Pull requests that update .net code
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants