Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Change go client factory to use credentials and scope #1394

Merged
merged 2 commits into from
Mar 1, 2023

Conversation

rkodev
Copy link
Contributor

@rkodev rkodev commented Feb 28, 2023

Resolves https://github.com/microsoftgraph/microsoft-graph-docs-contrib/issues/1366

Changes Go client factory
from graphClient := msgraphsdk.NewGraphServiceClient(requestAdapter)
to graphClient := msgraphsdk.NewGraphServiceClientWithCredentials(cred, scopes)

baywet
baywet previously approved these changes Feb 28, 2023
@baywet baywet enabled auto-merge (squash) February 28, 2023 18:26
@andrueastman andrueastman mentioned this pull request Mar 1, 2023
@rkodev rkodev disabled auto-merge March 1, 2023 12:25
@rkodev rkodev force-pushed the fix/update-go-client-factory branch from 4d915ac to 3e177ef Compare March 1, 2023 12:26
@rkodev rkodev enabled auto-merge (squash) March 1, 2023 12:29
@sonarqubecloud
Copy link

sonarqubecloud bot commented Mar 1, 2023

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

100.0% 100.0% Coverage
0.0% 0.0% Duplication

@rkodev rkodev merged commit a349313 into dev Mar 1, 2023
@rkodev rkodev deleted the fix/update-go-client-factory branch March 1, 2023 12:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

How do we create a RequestAdapter?
3 participants