Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update python snippet generation logic #1450

Merged
merged 86 commits into from
May 22, 2023
Merged

Update python snippet generation logic #1450

merged 86 commits into from
May 22, 2023

Conversation

shemogumbe
Copy link
Contributor

Overview

Add snippet Generation for Kiota based Python SDK

Brief description of what this PR does, and why it is needed.

Demo

Optional. Screenshots, curl examples, etc.

Notes

Optional. Ancillary topics, caveats, alternative strategies that didn't work out, anything else.

Testing Instructions

  • How to test this PR
  • Prefer bulleted description
  • Start after checking out this branch
  • Include any setup required, such as bundling scripts, restarting services, etc.
  • Include test case, and expected output

@shemogumbe shemogumbe changed the title Python/snippet generation Update python snippet generation logic Mar 23, 2023
shemogumbe added 27 commits March 28, 2023 17:33
@shemogumbe
Add python dot notation to generated snippets
b21a236
@shemogumbe
Python class instantiation
ddd5cc6
@shemogumbe
Convert to snake case and use await
c7e4872
@shemogumbe
convert request adapter to snake case
462e589
@shemogumbe
remove brackets for classnames with no parameters
409c8d2
@shemogumbe
Remove brackets for paths with no parameters
429d398
@shemogumbe
Remove trailing semi colons
d2652c5
@shemogumbe
Change ById to _by_id
af35083
@shemogumbe
Change ById to _by_id
584ca62
@shemogumbe
fix snake case for by_id
fa984b8
@shemogumbe
fix by id
af0d4a9
@shemogumbe
fix by id dot notation
03cf7b0
@shemogumbe
fix by id dot notation
8e29a86
@shemogumbe
fix by_id _ after entity
db20fee
@shemogumbe
Revert "fix by id dot notation"
8c23abf 
This reverts commit 03cf7b0.
@shemogumbe
fix snake case for by_id
1721f96
@shemogumbe
replace empty string with underscore for by_id prefix
d1299f2
@shemogumbe
Update query parameters and request headers
76031cd
@shemogumbe
Change request configurations - headers and query params
4b02e96
@shemogumbe
Update query parameters to pythonc array format
b9c5285
@shemogumbe
Revert "Update query parameters to pythonc array format"
4ed0219 
This reverts commit b9c5285.
@shemogumbe
Fix headers and parameters
8484ce7
@shemogumbe
Fix request headers and parameters
2c841be
@shemogumbe
Fixed tests on python generator
0270093
@shemogumbe
Remove request builder if there are no set parameters or headers
7e868e8
@shemogumbe
Add request builder to request builder method as prefix
3e86925
@shemogumbe
remove headers close tags if request configuration does not exist
d8f3ecc
andrueastman
andrueastman previously approved these changes Apr 25, 2023
View reviewed changes
samwelkanda
samwelkanda requested changes Apr 26, 2023
View reviewed changes
Copy link
Contributor

@samwelkanda samwelkanda left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for this! A few modifications needed due to recent breaking changes.

CodeSnippetsReflection.OpenAPI.Test/PythonGeneratorTests.cs Outdated Show resolved Hide resolved
CodeSnippetsReflection.OpenAPI.Test/PythonGeneratorTests.cs Outdated Show resolved Hide resolved
CodeSnippetsReflection.OpenAPI.Test/PythonGeneratorTests.cs Outdated Show resolved Hide resolved
CodeSnippetsReflection.OpenAPI.Test/PythonGeneratorTests.cs Outdated Show resolved Hide resolved
CodeSnippetsReflection.OpenAPI.Test/PythonGeneratorTests.cs Outdated Show resolved Hide resolved
CodeSnippetsReflection.OpenAPI.Test/PythonGeneratorTests.cs Outdated Show resolved Hide resolved
CodeSnippetsReflection.OpenAPI.Test/PythonGeneratorTests.cs Outdated Show resolved Hide resolved
@sonarqubecloud
Copy link

sonarqubecloud bot commented May 5, 2023

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 4 Code Smells

88.5% 88.5% Coverage
0.0% 0.0% Duplication

@shemogumbe shemogumbe merged commit f8dd23c into dev May 22, 2023
@shemogumbe shemogumbe deleted the python/snippet-generation branch May 22, 2023 16:00
@shemogumbe shemogumbe mentioned this pull request May 30, 2023
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@rkodev rkodev rkodev approved these changes

@samwelkanda samwelkanda samwelkanda approved these changes

@andrueastman andrueastman andrueastman left review comments

@irvinesunday irvinesunday Awaiting requested review from irvinesunday

@baywet baywet Awaiting requested review from baywet

@ddyett ddyett Awaiting requested review from ddyett

@MIchaelMainer MIchaelMainer Awaiting requested review from MIchaelMainer

@nikithauc nikithauc Awaiting requested review from nikithauc

@zengin zengin Awaiting requested review from zengin

@MaggieKimani1 MaggieKimani1 Awaiting requested review from MaggieKimani1

@fey101 fey101 Awaiting requested review from fey101

@adhiambovivian adhiambovivian Awaiting requested review from adhiambovivian

@danielmbaluka danielmbaluka Awaiting requested review from danielmbaluka

@millicentachieng millicentachieng Awaiting requested review from millicentachieng

@peombwa peombwa Awaiting requested review from peombwa

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@shemogumbe @andrueastman @samwelkanda @rkodev