Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update go snippet execution path #1502

Merged
merged 2 commits into from
Apr 17, 2023
Merged

Update go snippet execution path #1502

merged 2 commits into from
Apr 17, 2023

Conversation

rkodev
Copy link
Contributor

@rkodev rkodev commented Apr 17, 2023

Overview

Closes microsoftgraph/msgraph-sdk-go#458

Update go snippets indexer to use latest kiota changes microsoft/kiota#2528

Previous statement

result, err := graphClient.TeamsById("team-id").ChannelsById("channel-id").Messages().Post(context.Background(), requestBody, nil)

Current statement

result, err := graphClient.Teams().WithTeamId("team-id").Channels().WithChannelId("channel-id").Messages().Post(context.Background(), requestBody, nil)

Tested by unit tests

andrueastman
andrueastman previously approved these changes Apr 17, 2023
Copy link
Member

@baywet baywet left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

A last minute change was requested by the PM group. indexers are By, functions are with

CodeSnippetsReflection.OpenAPI.Test/GoGeneratorTests.cs Outdated Show resolved Hide resolved
@sonarqubecloud
Copy link

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

93.3% 93.3% Coverage
0.0% 0.0% Duplication

@rkodev rkodev enabled auto-merge (squash) April 17, 2023 15:13
@rkodev rkodev merged commit 911abf5 into dev Apr 17, 2023
@rkodev rkodev deleted the feat/snippets-go-path branch April 17, 2023 15:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
3 participants