Match path nodes with method on snippet generation #1570
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR updates the snippet generation logic to fail in the event at a path is found but the requested http method does not exist in the metadata to prevent the generation of methods that do not exist in snippets.
Changes have been benchmarked with the dev branch in the pipeline runs at the links below.
Dev - https://dev.azure.com/microsoftgraph/Graph%20Developer%20Experiences/_build/results?buildId=115361&view=ms.vss-test-web.build-test-results-tab&runId=1135195&resultId=100674&paneView=debug
This PR - https://dev.azure.com/microsoftgraph/Graph%20Developer%20Experiences/_build/results?buildId=115362&view=ms.vss-test-web.build-test-results-tab&runId=1135211&resultId=100115&paneView=debug
In summary, snippets generated will reduce by about 1% as summarized in the table below from the above runs,
Note
Pass rates in compilation stages will therefore go up due to the failed compilation snippets now not being generated.