Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixes incomplete snippets with expand query options and filter query options that use function operator types #1646

Conversation

timayabi2020
Copy link
Contributor

@timayabi2020 timayabi2020 commented Jun 28, 2023

Overview

Fixes #1627
Fixes #1626

Testing Instructions

  • Checkout branch associated with this PR
  • Run it locally and formulate the request as per the screenshots below showing the request and expected output.
image image

@timayabi2020 timayabi2020 requested a review from a team as a code owner June 28, 2023 16:49
Copy link
Member

@baywet baywet left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

FYI the syntax for GitHub is fixes #13099 (one per line, no comma etc...)

timayabi2020 and others added 3 commits June 28, 2023 21:28
…rator.cs

Co-authored-by: Vincent Biret <vibiret@microsoft.com>
…rator.cs

Co-authored-by: Vincent Biret <vibiret@microsoft.com>
timayabi2020 and others added 3 commits June 28, 2023 22:29
…rator.cs

Co-authored-by: Vincent Biret <vibiret@microsoft.com>
…rator.cs

Co-authored-by: Vincent Biret <vibiret@microsoft.com>
…rator.cs

Co-authored-by: Vincent Biret <vibiret@microsoft.com>
@sonarqubecloud
Copy link

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

100.0% 100.0% Coverage
0.0% 0.0% Duplication

@timayabi2020 timayabi2020 merged commit 7428ded into dev Jun 29, 2023
@timayabi2020 timayabi2020 deleted the 1627-cliincomplete-snippet-generation-for-http-snippets-with-expand-query-options branch June 29, 2023 02:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
2 participants