Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Updates go fluent path api #1679

Merged
merged 1 commit into from
Jul 24, 2023
Merged

Updates go fluent path api #1679

merged 1 commit into from
Jul 24, 2023

Conversation

rkodev
Copy link
Contributor

@rkodev rkodev commented Jul 24, 2023

Overview

Resolves microsoftgraph/msgraph-sdk-go#541

Fixes Go samples fluent api.

Demo

 # https://learn.microsoft.com/en-us/graph/api/worksheet-post-charts?view=graph-rest-1.0&tabs=http
 // current syntax 
result, err := graphClient.Drives().ByDriveId("drive-id").Items().ByItemId("driveItem-id").Workbook().Worksheets().ByWorksheetId("workbookWorksheet-id").Charts().Post(context.Background(), requestBody, nil)


// expected

result, err := graphClient.Drives().ByDriveId("drive-id").Items().ByDriveItemId("driveItem-id").Workbook().Worksheets().ByWorkbookWorksheetId("workbookWorksheet-id").Charts().Post(context.Background(), requestBody, nil)rkbook().Worksheets().ByWorksheetId("workbookWorksheet-id").Charts().Post(context.Background(), requestBody, nil)

Notes

Optional. Ancillary topics, caveats, alternative strategies that didn't work out, anything else.

Testing Instructions

  • Added unit tests

@rkodev rkodev requested a review from a team as a code owner July 24, 2023 12:16
@rkodev rkodev force-pushed the fix/update-go-fluent-name branch from 17c91de to 039d711 Compare July 24, 2023 13:27
@sonarqubecloud
Copy link

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

80.0% 80.0% Coverage
0.0% 0.0% Duplication

@rkodev rkodev enabled auto-merge (squash) July 24, 2023 13:39
Copy link
Member

@baywet baywet left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thanks for making the changes!

@rkodev rkodev merged commit 62aec68 into dev Jul 24, 2023
@rkodev rkodev deleted the fix/update-go-fluent-name branch July 24, 2023 14:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Fix 1K+ issues as a result of the inaccurate fluent path generated
2 participants