Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix PHP Snippets remove extra spaces and add wait() to fluent path #1709

Merged
merged 11 commits into from
Aug 15, 2023

Conversation

SilasKenneth
Copy link
Member

  • Remove additional spaces in the snippets.
  • Change tests to account for wait() in fluent path.

Overview

Brief description of what this PR does, and why it is needed.

Demo

Optional. Screenshots, curl examples, etc.

Notes

Optional. Ancillary topics, caveats, alternative strategies that didn't work out, anything else.

Testing Instructions

  • How to test this PR
  • Prefer bulleted description
  • Start after checking out this branch
  • Include any setup required, such as bundling scripts, restarting services, etc.
  • Include test case, and expected output

@SilasKenneth SilasKenneth requested a review from a team as a code owner August 14, 2023 11:45
@SilasKenneth SilasKenneth self-assigned this Aug 14, 2023
@SilasKenneth SilasKenneth enabled auto-merge (squash) August 14, 2023 13:42
@sonarqubecloud
Copy link

sonarqubecloud bot commented Aug 15, 2023

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

98.2% 98.2% Coverage
0.0% 0.0% Duplication

@SilasKenneth SilasKenneth merged commit fd4c3b3 into dev Aug 15, 2023
@SilasKenneth SilasKenneth deleted the fix/php-snippets-spacing branch August 15, 2023 10:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants