-
Notifications
You must be signed in to change notification settings - Fork 35
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Rsh/snippet generation java kiota #1748
Conversation
CodeSnippetsReflection.OpenAPI/LanguageGenerators/JavaGenerator.cs
Outdated
Show resolved
Hide resolved
CodeSnippetsReflection.OpenAPI/LanguageGenerators/JavaGenerator.cs
Outdated
Show resolved
Hide resolved
CodeSnippetsReflection.OpenAPI/LanguageGenerators/JavaGenerator.cs
Outdated
Show resolved
Hide resolved
Thanks for this @ramsessanchez. This looks great. Any chance you can checkout the sonarcloud warnings as well? Sample run at https://dev.azure.com/microsoftgraph/Graph%20Developer%20Experiences/_build/results?buildId=124526&view=results is timing out as current branch is missing changes from #1719. A rebase/merge from dev is needed too. |
Snippet generation for the Kiota based Java-Sdk (v6)
2610092
to
be577ab
Compare
There is one remaining code smell regarding the use of Last(), the smell suggests that using count-1 would be more efficient, however split returns an array so the smell actually is not helpful. |
Code smells / styling
b2a2d0f
to
6e2606e
Compare
@andrueastman I believe that we need to add the namespace change to dotNet snippet generation as well. While we can still use .me() the reference to the namespace .me was removed when we removed it during generation thus making some snippets uncompilable. |
b5c677b
to
e969720
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@andrueastman I believe that we need to add the namespace change to dotNet snippet generation as well. While we can still use .me() the reference to the namespace .me was removed when we removed it during generation thus making some snippets uncompilable.
Thanks for pointing this out @ramsessanchez, I've updated the issue description at microsoftgraph/msgraph-sdk-dotnet#1874 to capture this when this is implemented in the next breaking change for dotnet
Ready to merge, will continue fixes to snippet generation on later PR's |
CodeSnippetsReflection.OpenAPI/LanguageGenerators/JavaGenerator.cs
Outdated
Show resolved
Hide resolved
…r.cs Co-authored-by: Mustafa Zengin <muzengin@microsoft.com>
Kudos, SonarCloud Quality Gate passed! |
Fixes #1026
Adds snippet generation for the Kiota based Java-SDK using OpenApi