New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Rsh/java snippet generation debugging #1766

Merged

ramsessanchez merged 5 commits into dev from rsh/javaSnippetGeneration_debugging

Oct 6, 2023

Contributor

ramsessanchez commented Oct 5, 2023 •

edited

Loading

Adds microsoftExtensionParses to the OpenApiSnippetGenerator class, previously only on the OpenApiSnippetGeneratorTestBase which prevented correct flaggedEnum handling.
Correctly handles cases when multiple enums are present in a http payload.
Correct casing for all methods in execution method chains.
Adjust the 'ReplaceReservedName' method to match what is present in the Kiota Generator (ie "{type}Escaped" rather than {type}Object)
Current fail rate for Raptor tests is 137/3,194

Microsoft Reviewers: Open in CodeFlow

ramsessanchez added 5 commits

October 3, 2023 10:55


          generate kiota java snippets

fc3f453


          add microsoftExtensionParsers to OpenApiSnippetGenerator

fb47899


          fixes enum handling when payload describes multiple but request body …

095c02c

…accepts only one


          improved Namespace handling)

2bde54b


          adjust 'replaceIfReservedName' method to match kiota generation

d107c67

ramsessanchez requested a review from a team as a code owner

October 5, 2023 22:50

sonarqubecloud bot commented Oct 5, 2023

Kudos, SonarCloud Quality Gate passed!

0 Bugs
0 Vulnerabilities
0 Security Hotspots
0 Code Smells

100.0% Coverage
0.0% Duplication

andrueastman approved these changes

View reviewed changes

ramsessanchez merged commit 95fed0a into dev

11 checks passed

ramsessanchez deleted the rsh/javaSnippetGeneration_debugging branch

October 6, 2023 20:50

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet