Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Task: use kibali for permissions #1864

Merged
merged 27 commits into from
Jan 9, 2024
Merged

Task: use kibali for permissions #1864

merged 27 commits into from
Jan 9, 2024

Conversation

thewahome
Copy link
Contributor

@thewahome thewahome commented Nov 30, 2023 •
edited by microsoft-github-policy-service bot
Loading

Overview

takes Kibali as a dependency and

  • uses it to import and generate a permissions document
  • users Kibali's AuthZChecker class to get the permissions for a URL
Microsoft Reviewers: Open in CodeFlow

@thewahome thewahome requested a review from a team as a code owner November 30, 2023 15:31
@thewahome thewahome marked this pull request as draft November 30, 2023 15:32
@thewahome thewahome marked this pull request as ready for review November 30, 2023 19:20
@sonarqubecloud SonarQubeCloud
Copy link

sonarqubecloud bot commented Dec 7, 2023

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

80.0% 80.0% Coverage
0.0% 0.0% Duplication

andrueastman
andrueastman reviewed Dec 13, 2023
View reviewed changes
PermissionsService.Test/PermissionsStoreShould.cs Outdated Show resolved Hide resolved
PermissionsService/Services/PermissionsStore.cs Outdated Show resolved Hide resolved
PermissionsService/Services/PermissionsStore.cs Outdated Show resolved Hide resolved
PermissionsService/Services/PermissionsStore.cs Outdated Show resolved Hide resolved
@sonarqubecloud SonarQubeCloud
Copy link

sonarqubecloud bot commented Jan 8, 2024

Quality Gate Failed Quality Gate failed

Failed conditions

79.1% Coverage on New Code (required ≥ 80%)

See analysis details on SonarCloud

@thewahome thewahome merged commit 3a6b9c1 into dev Jan 9, 2024
10 of 11 checks passed
@thewahome thewahome deleted the task/use-kibali-for-permissions branch January 9, 2024 08:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@irvinesunday irvinesunday irvinesunday left review comments

@andrueastman andrueastman andrueastman approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@thewahome @andrueastman @irvinesunday