Fix: OCV Feedback rating (#1687)

microsoftgraph · May 11, 2022 · a25927a · a25927a
1 parent 70b4999
commit a25927a
Show file tree

Hide file tree

Showing 2 changed files with 61 additions and 58 deletions.
diff --git a/src/app/views/query-runner/request/feedback/campaignDefinitions.ts b/src/app/views/query-runner/request/feedback/campaignDefinitions.ts
@@ -7,74 +7,76 @@ const CampaignDefinitions: object[] = [{
  'GovernedChannelType': 0,
  'AdditionalDataRequested': ['EmailAddress'],
  'Scope':
+ {
+ 'Type': 0
+ },
+ 'NominationScheme':
+ {
+ 'Type': 0,
+ 'PercentageNumerator': 100,
+ 'PercentageDenominator': 100,
+ 'NominationPeriod':
  {
- 'Type': 0
+ 'Type': 0,
+ 'IntervalSeconds': (NODE_ENV === 'development') ? 120 : process.env.REACT_APP_NOMINATION_PERIOD
  },
- 'NominationScheme':
+  'CooldownPeriod':
  {
  'Type': 0,
- 'PercentageNumerator': 100,
- 'PercentageDenominator': 100,
- 'NominationPeriod':
- {
- 'Type': 0,
- 'IntervalSeconds':(NODE_ENV === 'development') ? 120 : process.env.REACT_APP_NOMINATION_PERIOD
- },
- 'CooldownPeriod':
- {
- 'Type': 0,
- 'IntervalSeconds': (NODE_ENV === 'development') ? 240 : process.env.REACT_APP_COOLDOWN_PERIOD
- },
- 'FallbackSurveyDurationSeconds': 120
+ 'IntervalSeconds': (NODE_ENV === 'development') ? 240 : process.env.REACT_APP_COOLDOWN_PERIOD
  },
+ 'FallbackSurveyDurationSeconds': 120
+ },
  'SurveyTemplate':
+ {
+ 'Type': 4,
+ 'ActivationEvent':
  {
- 'Type': 4,
- 'ActivationEvent':
- {
- 'Type': 1,
- 'Sequence':
- [{
- 'Type': 0,
- 'Activity': 'AppUsageTime',
- 'Count': (NODE_ENV === 'development') ? 60 : process.env.REACT_APP_USAGE_TIME, //in seconds
- 'IsAggregate': true
- },
- {
- 'Type': 0,
- 'Activity': 'AppResume',
- 'Count': 1,
- 'IsAggregate': false
- }
- ]
- },
- 'Content': {
- Prompt: {
- Title: 'Prompt_Title',
- Question: 'Prompt_Question',
- YesLabel: 'Prompt_YesLabel',
- NoLabel: 'Prompt_NoLabel'
- },
- Rating: {
- Question: 'Graph_Explorer_Rating_Question',
- RatingValuesAscending: [
- 'Rating_Values_1',
- 'Rating_Values_2',
- 'Rating_Values_3',
- 'Rating_Values_4',
- 'Rating_Values_5',
- 'Rating_Values_6',
- 'Rating_Values_7',
- 'Rating_Values_8',
- 'Rating_Values_9',
- 'Rating_Values_10'
- ]
+ 'Type': 1,
+ 'Sequence':
+ [{
+ 'Type': 0,
+ 'Activity': 'AppUsageTime',
+ 'Count': (NODE_ENV === 'development') ? 60 : process.env.REACT_APP_USAGE_TIME, //in seconds
+ 'IsAggregate': true
  },
- Question: {
- Question: 'Question_Question'
+ {
+ 'Type': 0,
+ 'Activity': 'AppResume',
+ 'Count': 1,
+ 'IsAggregate': false
  }
+ ]
+ },
+ 'Content': {
+ Prompt: {
+ Title: 'Prompt_Title',
+ Question: 'Prompt_Question',
+ YesLabel: 'Prompt_YesLabel',
+ NoLabel: 'Prompt_NoLabel'
+ },
+ Rating: {
+ IsZeroBased: true,
+ Question: 'Graph_Explorer_Rating_Question',
+ RatingValuesAscending: [
+ 'Rating_Values_0',
+ 'Rating_Values_1',
+ 'Rating_Values_2',
+ 'Rating_Values_3',
+ 'Rating_Values_4',
+ 'Rating_Values_5',
+ 'Rating_Values_6',
+ 'Rating_Values_7',
+ 'Rating_Values_8',
+ 'Rating_Values_9',
+ 'Rating_Values_10'
+ ]
+ },
+ Question: {
+ Question: 'Question_Question'
  }
  }
+ }
 }];
 
 export default CampaignDefinitions;

diff --git a/src/app/views/query-runner/request/feedback/uiStrings.ts b/src/app/views/query-runner/request/feedback/uiStrings.ts
@@ -6,7 +6,8 @@ export const uiStringMap: any = {
  Prompt_YesLabel: translateMessage('Sure'),
  Prompt_NoLabel: translateMessage('Sure'),
  Graph_Explorer_Rating_Question: translateMessage('Graph Rating Question'),
- Rating_Values_1: `1 - ${translateMessage('Not at all likely')}`,
+ Rating_Values_0: `0 - ${translateMessage('Not at all likely')}`,
+ Rating_Values_1: '1',
  Rating_Values_2: '2',
  Rating_Values_3: '3',
  Rating_Values_4: '4',