Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix: Response Preview truncation #1017

Merged
merged 1 commit into from
Jul 9, 2021
Merged

Conversation

ElinorW
Copy link
Collaborator

@ElinorW ElinorW commented Jul 7, 2021

Overview

Fixes response truncation observed when a user runs a query.
Fixes #957

Demo

before fix:
image

after fix:
image

Notes

If You get a 404-Bad request. Add 'ConsistencyLevel: eventual in the Request header tab

Testing Instructions

  • Load app.
  • Run
    GET https://graph.microsoft.com/v1.0/servicePrincipals$count=true&$search="displayName:teams"&$select=id,displayName.
  • Observe @odata.id field in the Response Preview.
  • Observe url is wrapped.

Copy link
Collaborator

@thewahome thewahome left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

SUPER!

@thewahome thewahome merged commit 109491d into dev Jul 9, 2021
thewahome added a commit that referenced this pull request Jul 15, 2021
* Fix: improve themes MessageBar colors (#1015)

* Feature: Have permissions be filtered (DelegatedWork or DelegatedPersonal) based on account type (#1008)

* Fix: url truncation (#1012)

* Fix: Response Preview truncation (#1017)

* Task: change sandbox URL (#992)
thewahome added a commit that referenced this pull request Jul 15, 2021
* Fix: url truncation (#1012)

* Fix: improve themes MessageBar colors (#1015)

* Fix: Response Preview truncation (#1017)

* Feature: Have permissions be filtered (DelegatedWork or DelegatedPersonal) based on account type (#1008)

* Fix: terminate process on entering multiple slash (#824)

* Task: change sandbox url (#992)
@thewahome thewahome deleted the fix/response-preview-truncation branch August 9, 2021 08:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Users cannot scroll horizontally on the response preview
2 participants