Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Feature: Unconsent permissions #2063

Merged
merged 97 commits into from
Nov 8, 2022
Merged

Feature: Unconsent permissions #2063

merged 97 commits into from
Nov 8, 2022

Conversation

Onokaev
Copy link
Contributor

@Onokaev Onokaev commented Aug 29, 2022 •
edited
Loading

Overview

Closes #1844

Demo

Optional. Screenshots, curl examples, etc.

Notes

Optional. Ancillary topics, caveats, alternative strategies that didn't work out, anything else.

Testing Instructions

  • Checkout to this branch

Test permissions tablist UI

  • Open Modify Permissions tab and observe fixes as pointed out on the issue

Test revoking of permissions

  • Try revoking without consenting to the required permissions that enable revoking i.e. DelegatedPermissionGrant.ReadWrite.All and Directory.Read.All and observe behavior & status message

Ensure that you have consented to the required permissions to enable consent before trying the following tests

  • Try revoking a default permission e.g. User.Read and observe behavior & status message.
  • Try revoking to any other permission and observe behavior.

@github-actions
Copy link
Contributor

Azure Static Web Apps: Your stage site is ready! Visit it here: https://jolly-sand-0ac78c710-2063.centralus.azurestaticapps.net

@github-actions
Copy link
Contributor

Azure Static Web Apps: Your stage site is ready! Visit it here: https://jolly-sand-0ac78c710-2063.centralus.azurestaticapps.net

@github-actions
Copy link
Contributor

Azure Static Web Apps: Your stage site is ready! Visit it here: https://jolly-sand-0ac78c710-2063.centralus.azurestaticapps.net

@github-actions
Copy link
Contributor

Azure Static Web Apps: Your stage site is ready! Visit it here: https://jolly-sand-0ac78c710-2063.centralus.azurestaticapps.net

@github-actions
Copy link
Contributor

github-actions bot commented Sep 1, 2022

Azure Static Web Apps: Your stage site is ready! Visit it here: https://jolly-sand-0ac78c710-2063.centralus.azurestaticapps.net

@github-actions
Copy link
Contributor

github-actions bot commented Sep 1, 2022

Azure Static Web Apps: Your stage site is ready! Visit it here: https://jolly-sand-0ac78c710-2063.centralus.azurestaticapps.net

@github-actions
Copy link
Contributor

github-actions bot commented Sep 2, 2022

Azure Static Web Apps: Your stage site is ready! Visit it here: https://jolly-sand-0ac78c710-2063.centralus.azurestaticapps.net

@github-actions
Copy link
Contributor

github-actions bot commented Sep 5, 2022

Azure Static Web Apps: Your stage site is ready! Visit it here: https://jolly-sand-0ac78c710-2063.centralus.azurestaticapps.net

@github-actions
Copy link
Contributor

github-actions bot commented Nov 1, 2022

Azure Static Web Apps: Your stage site is ready! Visit it here: https://jolly-sand-0ac78c710-2063.centralus.azurestaticapps.net

@github-actions
Copy link
Contributor

github-actions bot commented Nov 1, 2022

Azure Static Web Apps: Your stage site is ready! Visit it here: https://jolly-sand-0ac78c710-2063.centralus.azurestaticapps.net

@github-actions
Copy link
Contributor

github-actions bot commented Nov 1, 2022

Azure Static Web Apps: Your stage site is ready! Visit it here: https://jolly-sand-0ac78c710-2063.centralus.azurestaticapps.net

@github-actions
Copy link
Contributor

github-actions bot commented Nov 1, 2022

Azure Static Web Apps: Your stage site is ready! Visit it here: https://jolly-sand-0ac78c710-2063.centralus.azurestaticapps.net

@github-actions
Copy link
Contributor

github-actions bot commented Nov 2, 2022

Azure Static Web Apps: Your stage site is ready! Visit it here: https://jolly-sand-0ac78c710-2063.centralus.azurestaticapps.net

@github-actions
Copy link
Contributor

github-actions bot commented Nov 3, 2022

Azure Static Web Apps: Your stage site is ready! Visit it here: https://jolly-sand-0ac78c710-2063.centralus.azurestaticapps.net

@github-actions
Copy link
Contributor

github-actions bot commented Nov 3, 2022

Azure Static Web Apps: Your stage site is ready! Visit it here: https://jolly-sand-0ac78c710-2063.centralus.azurestaticapps.net

@github-actions
Copy link
Contributor

github-actions bot commented Nov 7, 2022

Azure Static Web Apps: Your stage site is ready! Visit it here: https://jolly-sand-0ac78c710-2063.centralus.azurestaticapps.net

@github-actions
Copy link
Contributor

github-actions bot commented Nov 8, 2022

Azure Static Web Apps: Your stage site is ready! Visit it here: https://jolly-sand-0ac78c710-2063.centralus.azurestaticapps.net

@thewahome thewahome changed the base branch from dev to release/6.6.0 November 8, 2022 06:29
@Onokaev Onokaev merged commit 26cfb1c into release/6.6.0 Nov 8, 2022
@sonarcloud
Copy link

sonarcloud bot commented Nov 8, 2022

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
No Duplication information No Duplication information

thewahome added a commit that referenced this pull request Nov 8, 2022
@thewahome
Chore (release): 7.0.0 (#2218)
1979149 
Features

* Feature: ABNF validation (#2044)

* Feature: Unconsent permissions (#2063)

Bug Fixes

* Fix: Prevent sample groups from collapsing (#2101)

* Fix: Remove float CSS property on snippets (#2106)

* Fix: Update wordSeparators in Monaco (#2109)

* Fix: Failing tests (#2144)

* Fix: failing tests [Attempt 2] (#2145)

* Fix: stop recursive deep copy (#2151)

* Fix: display suggestions for placeholder segments (#2156)

* Fix: Pass empty array to signOutSuccess when signing out (#2162)

* Fix: Permission search results (#2167)

* Fix: Component name on device characteristics event (#2173)

* Fix: Add consent status for successful consent (#2187)

Enhancements

* Task: Fix auto-collapsing of permissions items (#2099)

* Task: Take Modify Permissions out of preview (#2110)

* Task: fix accessibility unnecessary empty data scans (#2118)

* Task: Update doc.microsoft links to learn.microsoft (#2148)

* Task: Remove errors telemetry filter to capture more details (#2124)

* Task: Add Adaptive card templates to local repo (#2182)

* Task: Update adaptive cards templating (#2183)

* Task: more-info telemetry capture (#2188)

Dependencies

* Task: upgrade redux (#2179)

* Chore: Dependabot upgrades September 2022 (#2098)
@thewahome thewahome deleted the feature/unconsent-permissions branch November 10, 2022 07:47
ElinorW pushed a commit that referenced this pull request Dec 13, 2022
@github-actions
Chore: Update to 7.1.0 (#2299)
1f4c3c9 
Features

* Feature: ABNF validation (#2044)

* Feature: Unconsent permissions (#2063)

Bug Fixes

* Fix: Prevent sample groups from collapsing (#2101)

* Fix: Remove float CSS property on snippets (#2106)

* Fix: Update wordSeparators in Monaco (#2109)

* Fix: Failing tests (#2144)

* Fix: failing tests [Attempt 2] (#2145)

* Fix: stop recursive deep copy (#2151)

* Fix: display suggestions for placeholder segments (#2156)

* Fix: Pass empty array to signOutSuccess when signing out (#2162)

* Fix: Permission search results (#2167)

* Fix: Component name on device characteristics event (#2173)

* Fix: Add consent status for successful consent (#2187)

* Fix: history items (#2301)

Enhancements

* Task: Fix auto-collapsing of permissions items (#2099)

* Task: Take Modify Permissions out of preview (#2110)

* Task: fix accessibility unnecessary empty data scans (#2118)

* Task: Update doc.microsoft links to learn.microsoft (#2148)

* Task: Remove errors telemetry filter to capture more details (#2124)

* Task: Add Adaptive card templates to local repo (#2182)

* Task: Update adaptive cards templating (#2183)

* Task: more-info telemetry capture (#2188)

Dependencies

* Task: upgrade redux (#2179)

* Chore: Dependabot upgrades September 2022 (#2098)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@MaryannGitonga MaryannGitonga MaryannGitonga left review comments

@thewahome thewahome thewahome approved these changes

@ElinorW ElinorW Awaiting requested review from ElinorW

@adhiambovivian adhiambovivian Awaiting requested review from adhiambovivian

@millicentachieng millicentachieng Awaiting requested review from millicentachieng

@ddyett ddyett Awaiting requested review from ddyett

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Add support for unconsenting a permission
4 participants
@Onokaev @ElinorW @MaryannGitonga @thewahome