Chore: popups manager #2514

thewahome · 2023-04-17T08:22:44Z

Overview

Demo

In the component that you want to load another component as a dialog / modal / panel, simply:

import it using the usePopups hook
const { open: openPermissions } = usePopups('full-permissions', 'panel');

Then call it by passing in parameters

const openPermissionsPanel = () => {
    openPermissions({
      settings: {
        title: translateMessage('Permissions'),
        width: 'lg'
      }
    })
  }

Notes

Parameters in the functions are autocompleted e.g the component name and the type of display. The width in the settings

github-actions · 2023-04-17T08:42:02Z

Azure Static Web Apps: Your stage site is ready! Visit it here: https://jolly-sand-0ac78c710-2514.centralus.azurestaticapps.net

github-actions · 2023-04-17T09:40:01Z

Azure Static Web Apps: Your stage site is ready! Visit it here: https://jolly-sand-0ac78c710-2514.centralus.azurestaticapps.net

ElinorW

Seems like the "Download Postman Collection" button has moved to the right.

The rest all work and appear as expected 👍🏾

github-actions · 2023-04-26T08:43:41Z

Azure Static Web Apps: Your stage site is ready! Visit it here: https://jolly-sand-0ac78c710-2514.centralus.azurestaticapps.net

thewahome · 2023-04-26T08:47:35Z

Yes @ElinorW ... the button moved to where Fluent Defines Dialog Footer buttons to go. I didn't see there being a need to move it

github-actions · 2023-04-26T08:54:27Z

Azure Static Web Apps: Your stage site is ready! Visit it here: https://jolly-sand-0ac78c710-2514.centralus.azurestaticapps.net

src/app/services/context/popups-context/PopupsContext.tsx

github-actions · 2023-04-26T13:12:45Z

Azure Static Web Apps: Your stage site is ready! Visit it here: https://jolly-sand-0ac78c710-2514.centralus.azurestaticapps.net

thewahome · 2023-04-26T13:14:56Z

Yes @ElinorW ... the button moved to where Fluent Defines Dialog Footer buttons to go. I didn't see there being a need to move it

So previously we are the ones who changed the default Fluent behavior?

Not exactly. I chose to use the DialogFooter on the Panel and the Dialog components. And it sat right for both without changing anything. So it just made sense to leave it there

github-actions · 2023-04-26T14:36:15Z

Azure Static Web Apps: Your stage site is ready! Visit it here: https://jolly-sand-0ac78c710-2514.centralus.azurestaticapps.net

src/app/views/common/popups/DialogWrapper.tsx

github-actions · 2023-04-27T13:12:22Z

Azure Static Web Apps: Your stage site is ready! Visit it here: https://jolly-sand-0ac78c710-2514.centralus.azurestaticapps.net

Onokaev · 2023-04-28T08:50:41Z

The Modify permissions tab and permissions panel reload every time a consent/unconsent action is performed. The same behavior is not in dev

github-actions · 2023-05-02T08:32:30Z

Azure Static Web Apps: Your stage site is ready! Visit it here: https://jolly-sand-0ac78c710-2514.centralus.azurestaticapps.net

github-actions · 2023-05-02T08:48:36Z

Azure Static Web Apps: Your stage site is ready! Visit it here: https://jolly-sand-0ac78c710-2514.centralus.azurestaticapps.net

github-actions · 2023-05-02T09:45:28Z

Azure Static Web Apps: Your stage site is ready! Visit it here: https://jolly-sand-0ac78c710-2514.centralus.azurestaticapps.net

github-actions · 2023-05-02T11:14:49Z

Azure Static Web Apps: Your stage site is ready! Visit it here: https://jolly-sand-0ac78c710-2514.centralus.azurestaticapps.net

github-actions · 2023-05-02T12:48:00Z

Azure Static Web Apps: Your stage site is ready! Visit it here: https://jolly-sand-0ac78c710-2514.centralus.azurestaticapps.net

sonarcloud · 2023-05-02T13:18:44Z

Kudos, SonarCloud Quality Gate passed!

0 Bugs
0 Vulnerabilities
0 Security Hotspots
0 Code Smells

No Coverage information
No Duplication information

github-actions · 2023-05-02T13:21:29Z

Azure Static Web Apps: Your stage site is ready! Visit it here: https://jolly-sand-0ac78c710-2514.centralus.azurestaticapps.net

* Chore: Update to 8.2.0 (#2520) * Fix: Add retry handler for revoking permissions (#2515) * Fix: Modify permissions tab resize (#2523) * Feature: Surface documentation links (#2219) * Task: Add support for persisting collections (#2525) * Chore: popups manager (#2514) * Task: support multiple collections (#2549) * Task: Show feedback - add to collections (#2555) * Chore: change "remove" aria label (#2558) * Chore: append unique paths to collection (#2560) * Fix: Collections reducer failing test logic (#2573) * Task: Reorder revoking permission event messages (#2526) * Fix: Persist sample body (#2550) * Fix: collection status for nodes with IDs (#2575) * add tests * get url for id nodes * Chore: Update failing snapshots (#2571) * Chore: Uppercase methods (#2578) * Task: Dependabot upgrades for May (#2557) * Task: Add support for uploading postman collections (#2579) * Fix: Remove use of external label (#2582) * Chore: utilise resource paths (#2584) * Chore: ensure unique paths (#2586) * Chore: Dependabot upgrades - June (#2612) * Chore: Clear network error message (#2615) * Task: Add new permissions scopeType (#2585) * Bump version to 9.0.0 --------- Co-authored-by: EvansA <evansonoka05.j@gmail.com> Co-authored-by: Charles Wahome <thewahome.cw@gmail.com>

* Bump version to 8.1.0 * return playwright test branch condition * Fix: Missing return statement (#2507) * Bump version to 8.2.0 * Chore: Release 9.0.0 (#2619) * Chore: Update to 8.2.0 (#2520) * Fix: Add retry handler for revoking permissions (#2515) * Fix: Modify permissions tab resize (#2523) * Feature: Surface documentation links (#2219) * Task: Add support for persisting collections (#2525) * Chore: popups manager (#2514) * Task: support multiple collections (#2549) * Task: Show feedback - add to collections (#2555) * Chore: change "remove" aria label (#2558) * Chore: append unique paths to collection (#2560) * Fix: Collections reducer failing test logic (#2573) * Task: Reorder revoking permission event messages (#2526) * Fix: Persist sample body (#2550) * Fix: collection status for nodes with IDs (#2575) * add tests * get url for id nodes * Chore: Update failing snapshots (#2571) * Chore: Uppercase methods (#2578) * Task: Dependabot upgrades for May (#2557) * Task: Add support for uploading postman collections (#2579) * Fix: Remove use of external label (#2582) * Chore: utilise resource paths (#2584) * Chore: ensure unique paths (#2586) * Chore: Dependabot upgrades - June (#2612) * Chore: Clear network error message (#2615) * Task: Add new permissions scopeType (#2585) * Bump version to 9.0.0 --------- Co-authored-by: EvansA <evansonoka05.j@gmail.com> Co-authored-by: Charles Wahome <thewahome.cw@gmail.com> * Fix: Show documentation URL for supported Resource Explorer items (#2625) * Fix: Ensure collections are initiated in store (#2627) * Chore: Release 9.1.0 (#2694) * Create microsoft-graph-explorer-v4-branch-protection.yml (#2617) * Fix: Update dependencies with high security risk (#2631) * Fix: Get documentation on resource render (#2634) * Feature: Add flighting support (#2621) * FabricBot: Onboarding to GitOps.ResourceManagement because of FabricBot decommissioning (#2669) * Fix: Permissions scrollbar (#2576) * Fix: Bundle Monaco-editor package (#2677) * Fix: July Dependabot upgrades (#2679) * Fix: Update resource management bot (#2682) * Fix: Restore resources search box functionality (#2686) * Bump version to 9.1.0 * Bump version to 9.2.0 * Bump version to 9.3.0 * Fix: Remove component chunking (#2871) Temporarily removed until we have it working properly * Chore: Hotfix release 9.3.2 (#2898) * Hotfix: Upgrade msal-browser version (#2900) * Bump version to 9.4.0 * add CI:false * Chore: Release 9.5.0 (#2994) * Chore: Update to 9.4.0 (#2959) * Fix: Remove lazy loading on feedback button (#2963) * Fix: Ignore aria rule on Sample Queries component (#2962) * Chore: change workflow permissions (#2966) * Bump version to 9.5.0 --------- Co-authored-by: Charles Wahome <thewahome.cw@gmail.com> Co-authored-by: github-actions <github-actions@github.com> * Bump version to 9.6.0 * reset permissions to initial state on error * fix failing tests * Bump version to 9.7.0 --------- Co-authored-by: github-actions <github-actions@github.com> Co-authored-by: Elinor <ekaguongo@gmail.com> Co-authored-by: EvansA <evansonoka05.j@gmail.com> Co-authored-by: Elinor <elkaguon@microsoft.com>

thewahome added 16 commits April 3, 2023 17:43

add popups context

014816a

utilise context in hook

b7666db

define generic popups wrappers

4958e07

register sample popup

a742272

utilise provider in app.tsx

1e9621a

add new dialogcomponent for dialog uis

508d019

separate share query component from button

6f6d05f

separate theme chooser dialog

4f97454

move preview collections to popup manager

58a7a28

change component name to preview collection for clarity

074cc4a

change path name to collection

490dadd

define width of items in popup

e1d96df

use popups to open permissions

c56d0cd

remove permissions panel code

080c49c

break down permissions for better sharing

525ae26

rename files to clear intent

c39358c

thewahome requested review from ElinorW and Onokaev April 17, 2023 08:22

Merge branch 'dev' into chore/popups-manager

5f3a8b5

remove sonar cloud code smells

3706869

thewahome added 2 commits April 24, 2023 15:38

Merge branch 'dev' into chore/popups-manager

88eab5b

Merge branch 'dev' into chore/popups-manager

2f4b437

ElinorW reviewed Apr 26, 2023

View reviewed changes

Merge branch 'dev' into chore/popups-manager

c158800

ElinorW reviewed Apr 26, 2023

View reviewed changes

src/app/services/context/popups-context/PopupsContext.tsx Outdated Show resolved Hide resolved

add new size support

dcd9538

This comment was marked as outdated.

Sign in to view

Onokaev self-requested a review April 27, 2023 12:53

Onokaev reviewed Apr 27, 2023

View reviewed changes

src/app/views/common/popups/DialogWrapper.tsx Show resolved Hide resolved

add render footer function to show custom footers

533e340

ElinorW dismissed Onokaev’s stale review via 533e340 April 27, 2023 13:04

use show instead of open, reuse interfaces

4cbf217

add error boundary

6a2a0cc

prevent reload when consent is given

a1b60f5

remove dialog footer component

86874c6

move footer to the left with margin

1a73107

ElinorW previously approved these changes May 2, 2023

View reviewed changes

await promise in copy function

06ebf3b

thewahome dismissed ElinorW’s stale review via 06ebf3b May 2, 2023 13:13

thewahome merged commit cfb91a2 into dev May 2, 2023

thewahome deleted the chore/popups-manager branch May 3, 2023 07:16

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Chore: popups manager #2514

Chore: popups manager #2514

thewahome commented Apr 17, 2023

github-actions bot commented Apr 17, 2023

github-actions bot commented Apr 17, 2023

ElinorW left a comment •

edited

Loading

github-actions bot commented Apr 26, 2023

thewahome commented Apr 26, 2023

github-actions bot commented Apr 26, 2023

github-actions bot commented Apr 26, 2023

thewahome commented Apr 26, 2023 •

edited

Loading

github-actions bot commented Apr 26, 2023

This comment was marked as outdated.

github-actions bot commented Apr 27, 2023

Onokaev commented Apr 28, 2023

github-actions bot commented May 2, 2023

github-actions bot commented May 2, 2023

github-actions bot commented May 2, 2023

github-actions bot commented May 2, 2023

github-actions bot commented May 2, 2023

sonarcloud bot commented May 2, 2023

github-actions bot commented May 2, 2023

Chore: popups manager #2514

Chore: popups manager #2514

Conversation

thewahome commented Apr 17, 2023

Overview

Demo

Notes

github-actions bot commented Apr 17, 2023

github-actions bot commented Apr 17, 2023

ElinorW left a comment • edited Loading

Choose a reason for hiding this comment

github-actions bot commented Apr 26, 2023

thewahome commented Apr 26, 2023

github-actions bot commented Apr 26, 2023

github-actions bot commented Apr 26, 2023

thewahome commented Apr 26, 2023 • edited Loading

github-actions bot commented Apr 26, 2023

This comment was marked as outdated.

github-actions bot commented Apr 27, 2023

Onokaev commented Apr 28, 2023

github-actions bot commented May 2, 2023

github-actions bot commented May 2, 2023

github-actions bot commented May 2, 2023

github-actions bot commented May 2, 2023

github-actions bot commented May 2, 2023

sonarcloud bot commented May 2, 2023

github-actions bot commented May 2, 2023

ElinorW left a comment •

edited

Loading

thewahome commented Apr 26, 2023 •

edited

Loading