Fix: Monaco 404 errors #3222
Merged
Fix: Monaco 404 errors #3222
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
musale
reviewed
Jun 19, 2024
musale
reviewed
Jun 19, 2024
thewahome
previously approved these changes
Jun 19, 2024
Co-authored-by: Musale Martin <martinmusale@microsoft.com>
|
Azure Static Web Apps: Your stage site is ready! Visit it here: https://jolly-sand-0ac78c710-3222.centralus.azurestaticapps.net |
thewahome
approved these changes
Jun 19, 2024
|
Azure Static Web Apps: Your stage site is ready! Visit it here: https://jolly-sand-0ac78c710-3222.centralus.azurestaticapps.net |
1 similar comment
|
Azure Static Web Apps: Your stage site is ready! Visit it here: https://jolly-sand-0ac78c710-3222.centralus.azurestaticapps.net |
|
This was referenced Sep 25, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Overview
Fix #3221
updates code to fetch web workers from the correct destination
Demo
Updated
Notes
The worker URL functions previously existed but we removed them as we had stopped using the monaco-editor webpack plugin. Once we bundled Monaco, we resumed using the plugin and must have forgotten to update the worker urls.
Ref: #2615
Testing Instructions