Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Task: basic markdown messages #3280

Merged
merged 8 commits into from
Aug 13, 2024
Merged

Task: basic markdown messages #3280

merged 8 commits into from
Aug 13, 2024

Conversation

thewahome
Copy link
Collaborator

Overview

Closes #3279

Demo

<MessageDisplay message={`**${statusText} - **${status.toString()}`} onSetQuery={setQuery} />

image

image

Notes

Uses a builder to add values to the dom based on the markdown like features added

@thewahome thewahome requested a review from a team as a code owner August 8, 2024 14:47
Copy link
Contributor

github-actions bot commented Aug 8, 2024

Azure Static Web Apps: Your stage site is ready! Visit it here: https://jolly-sand-0ac78c710-3280.centralus.azurestaticapps.net

Copy link
Contributor

@musale musale left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@thewahome How do I test this?

@thewahome
Copy link
Collaborator Author

Select a query with a tip message. Some of them also have the URLs

Copy link
Contributor

@musale musale left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I like this! Please add a little bit of space between the http method name and the link
image

All in all, this is good to go.

Copy link
Contributor

Azure Static Web Apps: Your stage site is ready! Visit it here: https://jolly-sand-0ac78c710-3280.centralus.azurestaticapps.net

@thewahome thewahome merged commit 09e272f into dev Aug 13, 2024
19 of 20 checks passed
Copy link

sonarcloud bot commented Aug 13, 2024

@thewahome thewahome deleted the task/basic-markdown-messages branch August 19, 2024 09:25
@thewahome thewahome mentioned this pull request Aug 19, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Message handling for status display
2 participants