People Picker known issue fixes #136
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nmetulev
suggested changes
Aug 29, 2019
nmetulev
approved these changes
Aug 29, 2019
shweaver-MSFT
pushed a commit
that referenced
this pull request
Jun 8, 2020
* [people-picker] Adding documentation and basic custom css variables * [people-picker] removing console.log * [people-picker-documentation] fixing typo in documentation * [people-picker] updating arrow selection status * [people-picker] updating first selection is highlighted * [people-picker] updating docs to utilize real image * [people-picker] adding new file * [people-picker] changing text overflow property on selected people * [people-picker] changing text overflow property on selected people * [people-picker] updating selected people long string with css ellipses * [people-picker]updating centering of close icon * [people-picker] adding repeat instead of map, also caching images * [people-picker] adding timeout to boolean for no users found * [people-picker] updating image storing in case local storage doesn't exist * [people-picker] removing docs and adding pr fixes
shweaver-MSFT
pushed a commit
that referenced
this pull request
Jun 10, 2020
* [people-picker] Adding documentation and basic custom css variables * [people-picker] removing console.log * [people-picker-documentation] fixing typo in documentation * [people-picker] updating arrow selection status * [people-picker] updating first selection is highlighted * [people-picker] updating docs to utilize real image * [people-picker] adding new file * [people-picker] changing text overflow property on selected people * [people-picker] changing text overflow property on selected people * [people-picker] updating selected people long string with css ellipses * [people-picker]updating centering of close icon * [people-picker] adding repeat instead of map, also caching images * [people-picker] adding timeout to boolean for no users found * [people-picker] updating image storing in case local storage doesn't exist * [people-picker] removing docs and adding pr fixes
shweaver-MSFT
pushed a commit
that referenced
this pull request
Jun 10, 2020
* [people-picker] Adding documentation and basic custom css variables * [people-picker] removing console.log * [people-picker-documentation] fixing typo in documentation * [people-picker] updating arrow selection status * [people-picker] updating first selection is highlighted * [people-picker] updating docs to utilize real image * [people-picker] adding new file * [people-picker] changing text overflow property on selected people * [people-picker] changing text overflow property on selected people * [people-picker] updating selected people long string with css ellipses * [people-picker]updating centering of close icon * [people-picker] adding repeat instead of map, also caching images * [people-picker] adding timeout to boolean for no users found * [people-picker] updating image storing in case local storage doesn't exist * [people-picker] removing docs and adding pr fixes
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #121
PR Type
Bugfix
Description of the changes
references issues discussed in #121
PR checklist
Other information