-
Notifications
You must be signed in to change notification settings - Fork 306
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix(a11y): fix forced colors for file upload button #3114
Conversation
@Raisul123 I believe that this fixes the high contrast mode issue with the file upload button |
📖 The updated storybook is available here |
1 similar comment
📖 The updated storybook is available here |
📖 The updated storybook is available here |
packages/mgt-components/src/components/mgt-file-list/mgt-file-upload/mgt-file-upload.scss
Show resolved
Hide resolved
📖 The updated storybook is available here |
Hi @gavinbarron , |
@Raisul123 this follows the implementation of the fluent-button as seen here: https://fluent-components.azurewebsites.net/?path=/docs/components-button--button as you should see that implementation uses different colors and we simply are being consistent with that implementation. |
📖 The updated storybook is available here |
@Raisul123 can you offer any insight as to why the fluent-button that uses colors from the forced colors palette does not provide an acceptable solution? I suspect that I might have to mark this as A11yExternal as the colors that are being show here are the ones from the fluent-button. |
📖 The updated storybook is available here |
📖 The updated storybook is available here |
📖 The updated storybook is available here |
Hi @Mnickii and @gavinbarron, This issue is still repro on the updated URL as of now it is looks like a selected text and we have seen this behavior at Fluent side as well so could you please suggest us whether do we need to follow the external process and route this bug to Fluent team or not? |
Here we can see that these buttons follow the same colors in "Aquatic", given that these colors are applied in forced colors this behavior holds for "Desert", "Dusk", and "Night Sky". The fluent web component shows a repro here: https://fluent-components.azurewebsites.net/?path=/docs/components-button--button. Please route this issue to the fluent team as we're consistent with their implementation. |
📖 The updated storybook is available here |
|
📖 The updated storybook is available here |
Closes #3109
PR Type
Description of the changes
Adds forced-colors styles to ensure that the correct colors are applied when high contrast modes are selected
PR checklist
yarn build
) and changes have been tested in at least two supported browsers (Edge + non-Chromium based browser)yarn setLicense
)Other information