Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: disable input in single select mode and default userIds and groupIds #3119

Merged
merged 6 commits into from
Mar 11, 2024

Conversation

Mnickii
Copy link
Collaborator

@Mnickii Mnickii commented Mar 4, 2024

Closes #3066

PR Type

Bugfix

Description of the changes

Disables input on people-picker single-select mode in the case of default selected user Ids and group Ids

PR checklist

  • Project builds (yarn build) and changes have been tested in at least two supported browsers (Edge + non-Chromium based browser)
  • All public APIs (classes, methods, etc) have been documented following the jsdoc syntax
  • Stories have been added and existing stories have been tested
  • Added appropriate documentation. Docs PR:
  • License header has been added to all new source files (yarn setLicense)
  • Contains NO breaking changes

Other information

@Mnickii Mnickii requested a review from a team as a code owner March 4, 2024 09:49
Copy link

github-actions bot commented Mar 4, 2024

📖 The updated storybook is available here

1 similar comment
Copy link

github-actions bot commented Mar 4, 2024

📖 The updated storybook is available here

@microsoft-github-policy-service microsoft-github-policy-service bot added the Needs: Author Feedback Issue needs response from issue author label Mar 4, 2024
Copy link

github-actions bot commented Mar 4, 2024

📖 The updated storybook is available here

@microsoft-github-policy-service microsoft-github-policy-service bot removed the Needs: Author Feedback Issue needs response from issue author label Mar 5, 2024
Copy link

github-actions bot commented Mar 5, 2024

📖 The updated storybook is available here

sebastienlevert
sebastienlevert previously approved these changes Mar 5, 2024
Copy link
Contributor

@sebastienlevert sebastienlevert left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

Copy link

github-actions bot commented Mar 6, 2024

📖 The updated storybook is available here

@microsoft-github-policy-service microsoft-github-policy-service bot added the Needs: Author Feedback Issue needs response from issue author label Mar 6, 2024
Copy link

github-actions bot commented Mar 6, 2024

📖 The updated storybook is available here

Copy link

github-actions bot commented Mar 7, 2024

📖 The updated storybook is available here

@microsoft-github-policy-service microsoft-github-policy-service bot removed the Needs: Author Feedback Issue needs response from issue author label Mar 7, 2024
Copy link

github-actions bot commented Mar 7, 2024

📖 The updated storybook is available here

@Mnickii Mnickii requested a review from gavinbarron March 8, 2024 03:42
@gavinbarron gavinbarron enabled auto-merge (squash) March 8, 2024 19:07
Copy link

github-actions bot commented Mar 8, 2024

📖 The updated storybook is available here

Copy link

github-actions bot commented Mar 8, 2024

Code Coverage

Package Line Rate Branch Rate Complexity Health
mgt-components.src.components 86% 75% 0
mgt-components.src.components.mgt-contact 68% 83% 0
mgt-components.src.components.mgt-file 62% 100% 0
mgt-components.src.components.mgt-file-list 46% 100% 0
mgt-components.src.components.mgt-file-list.mgt-file-upload 49% 86% 0
mgt-components.src.components.mgt-get 22% 100% 0
mgt-components.src.components.mgt-messages 68% 100% 0
mgt-components.src.components.mgt-organization 47% 100% 0
mgt-components.src.components.mgt-person 82% 100% 0
mgt-components.src.components.mgt-person-card 77% 49% 0
mgt-components.src.components.mgt-picker 80% 100% 0
mgt-components.src.components.mgt-profile 40% 100% 0
mgt-components.src.components.mgt-tasks-base 87% 100% 0
mgt-components.src.components.mgt-theme-toggle 100% 100% 0
mgt-components.src.components.mgt-todo 79% 100% 0
mgt-components.src.components.sub-components.mgt-flyout 78% 53% 0
mgt-components.src.components.sub-components.mgt-spinner 100% 100% 0
mgt-components.src.graph 38% 78% 0
mgt-components.src.styles 92% 80% 0
mgt-components.src.utils 79% 27% 0
mgt-element.dist.es6.components.src.components 72% 73% 0
mgt-element.dist.es6.mock.src.mock 91% 73% 0
mgt-element.dist.es6.providers.src.providers 85% 76% 0
mgt-element.dist.es6.src 91% 80% 0
mgt-element.dist.es6.utils.src.utils 67% 71% 0
mgt-element.src 93% 40% 0
mgt-element.src.components 78% 100% 0
mgt-element.src.mock 81% 56% 0
mgt-element.src.providers 83% 100% 0
mgt-element.src.utils 71% 90% 0
Summary 67% (14504 / 21520) 74% (514 / 694) 0

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

[BUG] [mgt-people-picker] search is enabled even if a user is selected and mode is single
4 participants