Skip to content
This repository has been archived by the owner on May 17, 2023. It is now read-only.

Feat/exception handling #10

Merged
merged 24 commits into from
Aug 27, 2020
Merged

Feat/exception handling #10

merged 24 commits into from
Aug 27, 2020

Conversation

jobala
Copy link
Contributor

@jobala jobala commented Aug 24, 2020

Overview

This PR adds exception handlers for 403 and ClientAuthenticationErrors.

Screenshots

image

image

@jobala jobala marked this pull request as ready for review August 24, 2020 09:34
@jobala jobala requested review from zengin and ddyett August 24, 2020 09:38
MIchaelMainer
MIchaelMainer suggested changes Aug 25, 2020
View reviewed changes
Copy link
Contributor

@MIchaelMainer MIchaelMainer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We should define a set of custom CLIError objects to represent the different types of errors that may be raised by this CLI.

msgraph/cli/core/custom_browser_credential.py Outdated Show resolved Hide resolved
msgraph/cli/core/custom_browser_credential.py Show resolved Hide resolved
msgraph/cli/core/custom_browser_credential.py Show resolved Hide resolved
msgraph/cli/core/invocation.py Show resolved Hide resolved
msgraph/cli/core/invocation.py Show resolved Hide resolved
msgraph/cli/core/invocation.py Show resolved Hide resolved
msgraph/cli/command_modules/authentication/__init__.py Show resolved Hide resolved
msgraph/cli/command_modules/authentication/_exception_handler.py Show resolved Hide resolved
msgraph/cli/command_modules/authentication/_exception_handler.py Show resolved Hide resolved
msgraph/cli/command_modules/authentication/custom.py Show resolved Hide resolved
@MIchaelMainer MIchaelMainer mentioned this pull request Aug 27, 2020
Open
@jobala jobala merged commit a41a655 into main Aug 27, 2020
@jobala jobala deleted the feat/exception-handling branch August 27, 2020 18:00
@jobala jobala restored the feat/exception-handling branch August 27, 2020 18:05
@calebkiage calebkiage deleted the feat/exception-handling branch November 26, 2021 13:31
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@MIchaelMainer MIchaelMainer MIchaelMainer approved these changes

@zengin zengin Awaiting requested review from zengin

@ddyett ddyett Awaiting requested review from ddyett

@peombwa peombwa Awaiting requested review from peombwa

@nikithauc nikithauc Awaiting requested review from nikithauc

@baywet baywet Awaiting requested review from baywet

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@jobala @MIchaelMainer