Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Generated v1.0 models and request builders using Kiota #1283

Merged
merged 1 commit into from
Mar 22, 2022

Conversation

github-actions[bot]
Copy link
Contributor

@github-actions github-actions bot commented Mar 22, 2022

This pull request was automatically created by the GitHub Action, create pull request.

The commit hash is 0757391.

Important Check for unexpected deletions or changes in this PR.

  • Check that the changes match the changes in the captured commit for openapi.yaml
Microsoft Reviewers: Open in CodeFlow

@andrueastman andrueastman deleted the kiota/v1.0/pipelinebuild/70873 branch March 22, 2022 12:33
@andrueastman
Copy link
Member

Fixes

  • return types for Count request builders from string to int
  • unnecessary wrapper objects for function/actions results like CreateUploadSession

@baywet
Copy link
Member

baywet commented Mar 22, 2022

thanks for the confirmation here! I also saw the count fixes in Go, it's awesome to see those flow across multiple languages!
Don't forget to add a reference to Microsoft.Kiota.Serialization.Text as well for the count endpoints to work properly :)

@andrueastman
Copy link
Member

Thanks @baywet.

Don't forget to add a reference to Microsoft.Kiota.Serialization.Text as well for the count endpoints to work properly :)

This is already flowing in from the core dependency here so that we manage it from one place. Actually, the build would fail if we don't include it due to this reference.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants