-
Notifications
You must be signed in to change notification settings - Fork 10
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Ft page iterator #13 #27
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
good first draft, added a few comments.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
almost there! some minor changes. Don't hesitate to switch the PR to ready whenever it's ready.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
thanks for making the changes! only two docs comments missing and we should be good to go.
I also configured sonarcloud to exclude internal package from the metrics so it reflects the actual coverage.
Also please update the changelog https://github.com/microsoftgraph/msgraph-sdk-go-core/blob/main/CHANGELOG.md |
Kudos, SonarCloud Quality Gate passed! |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
thanks for the excellent work!
Overview
Adds PageIterator
Demo
Create a page iterator task
Iterate
Pause & Resume
Notes
Testing
Closes #13